Moves kaska main to its own entry point#28
Merged
jgomezdans merged 10 commits intomasterfrom Sep 9, 2019
Merged
Conversation
ilectra
approved these changes
Aug 21, 2019
Contributor
ilectra
left a comment
ilectra
left a comment
There was a problem hiding this comment.
I've added a bunch of things, so technically someone else has to review it now.... David?...
Contributor
|
The entry script - copied over from |
jgomezdans
approved these changes
Sep 9, 2019
Collaborator
jgomezdans
left a comment
jgomezdans
left a comment
There was a problem hiding this comment.
Looks sensible, I guess I always envisaged someone using things as a library, but having a single function to call the entire thing actually looks like a good idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3