Skip to content

Conversation

@jairomelo
Copy link

I struggled to find a natural 'landing spot' for the CSS-HTML relation and the concept of selectors, primarily because selectors aren't explicitly used in the current lesson examples. I’m also hesitant to link selectors strictly to CSS, as they are a broader mechanism used by JS and other tools to target elements.

However, I’ve updated the chapter outputs and fixed the anchor href retrieval logic.

If anyone has a suggestion for where the CSS/Selector concept fits best without feeling forced, I’m open to ideas!

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/UCSBCarpentry/web-scraping-python/compare/md-outputs..md-outputs-PR-3

The following changes were observed in the rendered markdown documents:

 a-real-website.md | 26 ++++++++++++++++----------
 md5sum.txt        |  2 +-
 2 files changed, 17 insertions(+), 11 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-01-26 19:56:45 +0000

github-actions bot pushed a commit that referenced this pull request Jan 26, 2026
@josenino95
Copy link

josenino95 commented Jan 26, 2026

Ok, I did some reviewing and undid some of the changes you made:

  • The updating of the workshop results, as I don't think it's worth it as they will keep getting outdated
  • You removed the .find('h3') for getting the links, as you correctly noticed it's not needed as the desired links are the first present in the tag we were already working in. However, I think that leaving the h3 allows us to see kind of the tree structure of the html

I'll add my comments on selectors after this

@josenino95
Copy link

Ok, now on the selectors section. (Seeing Selenium and Playwright documentation I noticed they started calling it locators)

  • I think the best way to add it is as a callout block, or as a spoiler block
  • The best place would be right after showing we can also use class_ to find the info we want, and that would at line 133 of the current a-real-website.md file
  • I think the best way to add it is suggesting a discussion on what possible ways are there to locate an element in an HTML (Something with a title like 'Other ways of locating elements in HTML'). It would talk about HTML, CSS, XPath (including the nice graphic Julien shared); a brief comment of their pros and cons; and maybe even mention that in DevTools you can copy any of them with right-click.

@josenino95
Copy link

josenino95 commented Jan 27, 2026

I'll merge this PR for the corrections to be ready for our workshop tomorrow, but opening a new issue to continue talking more about the pending topics

@josenino95 josenino95 merged commit eebb572 into UCSBCarpentry:main Jan 27, 2026
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
Auto-generated via `{sandpaper}`
Source  : eebb572
Branch  : main
Author  : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time    : 2026-01-27 00:24:05 +0000
Message : Merge pull request #3 from jairomelo/realwebsite

Realwebsite
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
Auto-generated via `{sandpaper}`
Source  : 43b6d7a
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-01-27 00:24:41 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : eebb572
Branch  : main
Author  : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time    : 2026-01-27 00:24:05 +0000
Message : Merge pull request #3 from jairomelo/realwebsite

Realwebsite
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
Auto-generated via `{sandpaper}`
Source  : 43b6d7a
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-01-27 00:24:41 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : eebb572
Branch  : main
Author  : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time    : 2026-01-27 00:24:05 +0000
Message : Merge pull request #3 from jairomelo/realwebsite

Realwebsite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants