Skip to content

feat: Offer --cache option to control cache mode (Incremental Build)#1368

Merged
maxreichmann merged 9 commits into
feat/incremental-build-4from
feat/incremental-build-cache-mode
May 26, 2026
Merged

feat: Offer --cache option to control cache mode (Incremental Build)#1368
maxreichmann merged 9 commits into
feat/incremental-build-4from
feat/incremental-build-cache-mode

Conversation

@maxreichmann
Copy link
Copy Markdown
Member

@maxreichmann maxreichmann commented Apr 28, 2026 •
edited
Loading

Part of Incremental Build: #1267

JIRA: CPOUI5FOUNDATION-1208

  • Introduce --cache with values "Default", "ReadOnly", "Force" and "Off" for commands "ui5 build" and "ui5 serve"
    • Add yargs help description (also appears in CLI docs)
  • Add JSDoc annotations
  • Rename --cache-mode to --snapshot-cache
    • Hide deprecated option in yargs help (if still used -> logs warning)
    • Legacy logic now usable via new name
    • Add hint under "Migrate to v5" in docs explaining this

@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from 13173d5 to 68a130f Compare April 29, 2026 07:39
@maxreichmann maxreichmann marked this pull request as draft April 29, 2026 07:42
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from 68a130f to 0c087f8 Compare April 29, 2026 08:23
@RandomByte RandomByte force-pushed the feat/incremental-build-4 branch from e1d781f to ab65f27 Compare April 30, 2026 12:19
RandomByte
RandomByte requested changes May 4, 2026
View reviewed changes
Comment thread packages/cli/lib/cli/commands/build.js Outdated
Comment thread packages/cli/lib/cli/commands/build.js Outdated
@maxreichmann maxreichmann force-pushed the feat/incremental-build-4 branch from 7aa4cd3 to 95fd5de Compare May 5, 2026 13:14
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from e451d07 to 07a5941 Compare May 7, 2026 15:25
@maxreichmann maxreichmann marked this pull request as ready for review May 7, 2026 15:31
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from bbf7099 to 39431de Compare May 7, 2026 15:32
@maxreichmann maxreichmann requested review from a team and RandomByte May 7, 2026 15:32
@RandomByte RandomByte force-pushed the feat/incremental-build-4 branch from 0670d94 to d029efb Compare May 11, 2026 08:45
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch 2 times, most recently from 7994eae to 2546932 Compare May 11, 2026 10:25
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from 2546932 to 4db0fca Compare May 11, 2026 10:32
@maxreichmann
Copy link
Copy Markdown
Member Author

maxreichmann commented May 11, 2026 •
edited
Loading

Rebased onto base branch feat/incremental-build-4 and fixed all unit tests which are not failing in base branch.

@maxreichmann maxreichmann requested review from RandomByte and removed request for RandomByte May 11, 2026 12:43
@maxreichmann
refactor: Fix unit tests
f2ff30d 
Fix all unit tests which are NOT failing in base branch ("feat-incremental-build-4")
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from cafca18 to f2ff30d Compare May 12, 2026 09:24
@maxreichmann maxreichmann force-pushed the feat/incremental-build-4 branch from 4be8ab8 to 7164b79 Compare May 13, 2026 12:35
RandomByte
RandomByte requested changes May 13, 2026
View reviewed changes
Comment thread internal/documentation/docs/updates/migrate-v5.md Outdated
@RandomByte RandomByte requested a review from KlattG May 13, 2026 15:16
@RandomByte
Copy link
Copy Markdown
Member

RandomByte commented May 13, 2026

Adding @KlattG since this PR changes a lot of user-facing texts

@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from 6e065f0 to db051ab Compare May 19, 2026 11:43
flovogt
flovogt reviewed May 19, 2026
View reviewed changes
Comment thread internal/documentation/docs/updates/migrate-v5.md Outdated
@maxreichmann @flovogt
docs: Fix Migrate-v5 hints (@flovogt review)
876b2f3 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from 7dec71b to 876b2f3 Compare May 19, 2026 14:56
@RandomByte RandomByte force-pushed the feat/incremental-build-4 branch from c9c4972 to 2862e0f Compare May 20, 2026 14:31
KlattG
KlattG previously requested changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, just a few things I noticed

Comment thread internal/documentation/docs/updates/migrate-v5.md Outdated
Comment thread packages/cli/lib/cli/commands/build.js Outdated
Comment thread packages/cli/lib/cli/commands/build.js Outdated
Comment thread packages/cli/lib/cli/commands/serve.js Outdated
Comment thread packages/cli/lib/cli/commands/serve.js Outdated
Comment thread packages/project/lib/build/cache/Cache.js Outdated
@maxreichmann @KlattG
docs: Refactor user-facing text (Address @KlattG review)
26a308a 
Co-authored-by: Günter Klatt <guenter.klatt@sap.com>
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from 6b89af1 to d18fba9 Compare May 26, 2026 09:30
@maxreichmann maxreichmann requested a review from a team May 26, 2026 09:35
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch 2 times, most recently from 06d7a70 to 2b2d697 Compare May 26, 2026 10:33
@maxreichmann maxreichmann force-pushed the feat/incremental-build-cache-mode branch from 2b2d697 to 1b9a3ea Compare May 26, 2026 10:34
@maxreichmann maxreichmann merged commit cbfe225 into feat/incremental-build-4 May 26, 2026
1 check passed
@maxreichmann maxreichmann deleted the feat/incremental-build-cache-mode branch May 26, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flovogt flovogt flovogt left review comments

@RandomByte RandomByte RandomByte approved these changes

@KlattG KlattG KlattG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maxreichmann @RandomByte @flovogt @KlattG