Resolve minor linter findings#1395
Merged
Merged
Conversation
The early-return check `!projectCustomMiddleware.length === 0` parses as `(!length) === 0`, which is always false for both empty and non-empty arrays. The branch never fired, but the for-loop below already handles empty arrays as a no-op, so behavior was unchanged. Initially found by @EdrilanBerisha in #1391
The TypeError thrown when a sap.ui.define dependency element is not a string literal had no message, leaving no context when the build failed on malformed input.
d3xter666
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by #1391 (credit to @EdrilanBerisha) I ran the "recommended" rules of https://github.com/sindresorhus/eslint-plugin-unicorn (which includes a "no-negation-in-equality-check" rule that is missing from eslint).
There are a lot of stylistic findings, and only two seem to have actual impact at runtime. Hence not adding unicorn as a plugin but fixing the two identified problems.