Missing autofix for methods offered on the global jQuery object can be replaced by native browser APIs

[flovogt]

Missing autofix for methods offered on the global jQuery object can be replaced by native browser APIs

Methods offered on the global jQuery object can be replaced by native browser APIs are deprecated. Therefore an autofix should be offered by UI5 linter.

Deprecated APIs:

• jQuery.sap.resources.isBundle
• jQuery.device.is.standalone
• jQuery.support.retina (out of scope)
• jQuery.sap.startsWith
• jQuery.sap.startsWithIgnoreCase
• jQuery.sap.endsWith
• jQuery.sap.endsWithIgnoreCase
• jQuery.sap.padLeft
• jQuery.sap.padRight
• jQuery.sap.delayedCall (extracted into Missing autofix related to jQuery.sap #657)
• jQuery.sap.clearDelayedCall (extracted into Missing autofix related to jQuery.sap #657)
• jQuery.sap.clearIntervalCall (extracted into Missing autofix related to jQuery.sap #657)
• jQuery.sap.intervalCall (extracted into Missing autofix related to jQuery.sap #657)
• jQuery.sap.domById
• jQuery.sap.isEqualNode
• jQuery.sap.newObject
• jQuery.sap.getter
• jQuery.inArray
• jQuery.isArray

Deprecated Usage

var isBundle = jQuery.sap.resources.isBundle(new sap.base.i18n.ResourceBundle());

var isStandAlone = jQuery.device.is.standalone;
var retinaDisplay = jQuery.support.retina;
var startsWithH = jQuery.sap.startsWith("Hello", "H");
var startsWithHOrh = jQuery.sap.startsWithIgnoreCase("Hello", "h");
var endsWithY = jQuery.sap.endsWith("Hello Y", "Y");
var endsWithYOry = jQuery.sap.endssWithIgnoreCase("Hello Y", "y");
var padLeft = jQuery.sap.padLeft("a", "0", 4); // returns "000a";
var padRight = jQuery.sap.padRight("a", "0", 4); // returns "a000";

var myObject = {};
myObject.myFunction = function(param1, param2) {};
var delayedCallId = jQuery.sap.delayedCall(1000, myObject, "myFunction", ["myParam1", "myParam2"]);
jQuery.sap.clearDelayedCall(delayedCallId);
var intervalCallId = jQuery.sap.intervalCall(1000, myObject, "myFunction", ["myParam1", "myParam2"]);
jQuery.sap.clearIntervalCall(intervalCallId);

var element = jQuery.sap.domById("popup");
const divList = document.getElementsByTagName("div");
var isEqNode = jQuery.sap.isEqualNode(divList[0], divList[0]);

var person = {firstname: "Peter", lastname: "Miller" };
var newObj = jQuery.sap.newObject(person);
var getPerson = jQuery.sap.getter(person);

var myData = ["a", "b", "c"];
var indexOfEntity = jQuery.inArray("b", myData);
var isValueAnArray = jQuery.isArray(myData);

Recommended Usage

sap.ui.define([
  "sap/base/i18n/ResourceBundle"
], (ResourceBundle) => {
  "use strict";
  var isBundle = new ResourceBundle() instanceof ResourceBundle;

  var isStandAlone = window.navigator.standalone;
  var retinaDisplay = window.devicePixelRatio >= 2;
  var startsWithH = "Hello".startsWith("H");
  var startsWithHOrh = "Hello".toLowerCase().startsWith("h".toLowerCase());
  var endsWithH = "Hello Y".endsWith("Y");
  var endssWithHOrh = "Hello Y".toLowerCase().endsWith("y".toLowerCase());
  var padLeft = "a".padStart(4, "0"); // returns "000a";
  var padRight = "a".padEnd(4, "0"); // returns "a000";

  var myObject = {};
  myObject.myFunction = function(param1, param2) {};
  var delayedCallId = window.setTimeout(myObject.myFunction, 1000, "myParam1", "myParam2");
  window.clearTimout(delayedCallId);
  var intervalCallId =  window.setTimeout(myObject.myFunction, 1000, "myParam1", "myParam2");
  window.clearInterval(intervalCallId);

  var element = window.document.getElementById("popup");
  var divList = document.getElementsByTagName("div");
  var isEqNode = divList[0].isEqualNode(divList[0]);
  
  var getPerson = function(value) { return function() { return value; }; }(person);
  var myData = ["a", "b", "c"];
  var indexOfEntity = (myData ? Array.prototype.indexOf.call(myData, "b") : -1);
  var isValueAnArray = Array.isArray(myData);
});

[flovogt]

Will be implemented in CPOUI5FOUNDATION-990.

[flovogt]

• The replacement for jQuery.sap.delayedCall and jQuery.sap.intervallCall requires multiple runs as the callback function can have things that need to be replaced, too. So, the the current implementation of UI5 linter would throws an error in this case as it has several replacements in the same position. (see Missing autofix related to jQuery.sap #657)
• jQuery.inArray is not specific to the jQuery.sap namespace it's a general jQuery deprecation, currently out of scope (see Missing autofix for jQuery global usage #586)
• jQuery.isArray is not specific to the jQuery.sap namespace it's a general jQuery deprecation, currently out of scope (see Missing autofix for jQuery global usage #586)