fix: Valid Js syntax after XML transpilation#552
Merged
Conversation
flovogt
reviewed
Feb 19, 2025
| });␊ | ||
| ␊ | ||
| export default const oView = new View({␊ | ||
| const oView = new View({␊ |
Member
Author
There was a problem hiding this comment.
Basically, this is the simplest solution that will not break anything.
The impact of this change is just the export of XMLView.
However, if we want to implement export default new View..., then we'll need to also modify the code for variable declaration & initialization which resides in another module and will definitelly imact the other scenarios
matz3
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an issue where the tranpiled XML->Js is exported with a syntax error.
Now this is fixed and the export statements are valid.
Currently, this is not an issue for the linter, but in future this might lead to unexpected results if we try to analyze exports.