Skip to content

Conversation

@d3xter666
Copy link
Member

fixes: #972

@d3xter666 d3xter666 requested a review from a team January 28, 2026 13:16
@coveralls
Copy link

coveralls commented Jan 28, 2026

Coverage Status

coverage: 86.796% (+0.01%) from 86.782%
when pulling f158970 on fix-teststarter-false-positive
into 6635730 on main.

@matz3
Copy link
Member

matz3 commented Jan 28, 2026

Fixing false positives causes more warnings in our fixtures? Is that really the expected outcome? 🤔

@codeworrior
Copy link
Member

Fixing false positives causes more warnings in our fixtures? Is that really the expected outcome? 🤔

I think this is caused by the fact that now every script tag is reported when no script tag indicates a use of the test starter. In the fixture, 3 scripts are included. Not sure whether this approach is helpful for developers. I understand that we can't easily pick the one script that should be changed. But wouldn't it be sufficient to create a single message for the whole HTML file?

@d3xter666 d3xter666 force-pushed the fix-teststarter-false-positive branch from 8ba2266 to f158970 Compare January 29, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linter unnecessarily suggests to use test starter when there's more than one script tag in an HTML page

4 participants