Conversation
In general not affecting consumers, they can remain on TS 5.x. But: BREAKING CHANGE: The re-exported ModuleResolutionKind enum no longer includes the deprecated NodeJs value. Consumers using ModuleResolutionKind.NodeJs must switch to Node16. The runCheck CLI now uses Node16 module resolution instead of Node10, which enforces file extensions and respects package.json exports. Adapt all tsconfigs for TS6 changed defaults: - explicit types arrays (TS6 defaults to []) - explicit rootDir (TS6 requires it with outDir) - explicit strict: false where previously relying on default - moduleResolution: "node" → "bundler" in test-packages - dedicated tsconfig for API type-check test (TS6 errors on tsc + files + tsconfig)
There was a problem hiding this comment.
Pull request overview
Updates the monorepo toolchain to TypeScript 6.0.3 and adjusts various configs/tests to accommodate TS6 default/behavior changes (notably module resolution and explicit compiler options), including a breaking change around ModuleResolutionKind.NodeJs removal from the re-exported enum.
Changes:
- Bump TypeScript to
6.0.3in root and relevant workspace packages, plus lockfile updates. - Update test package
tsconfig.jsonfiles (e.g.moduleResolution: "bundler", explicittypes,rootDir,strict/skipLibCheck). - Adjust
@ui5/dts-generatorchecks/tests to useModuleResolutionKind.Node16and add a dedicatedtsconfigfor API type-checking.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates TypeScript resolution to 6.0.3 in the lockfile (while still retaining a 5.9.3 entry due to downstream constraints). |
| package.json | Bumps root devDependency TypeScript to 6.0.3. |
| test-packages/typed-json-model/tsconfig.json | Switches module resolution to bundler and removes redundant baseUrl/paths entries. |
| test-packages/typed-json-model/package.json | Bumps local TypeScript devDependency to 6.0.3. |
| test-packages/openui5-snapshot-test/tsconfig.json | Sets moduleResolution to bundler for TS6 behavior alignment. |
| test-packages/openui5-snapshot-test/package.json | Bumps local TypeScript dependency to 6.0.3. |
| packages/ts-interface-generator/tsconfig-testwebcomponent.json | Adds explicit types: ["openui5"] to stabilize TS6 default type inclusion. |
| packages/ts-interface-generator/tsconfig-testmanagedobject.json | Adds explicit types: ["openui5"] to stabilize TS6 default type inclusion. |
| packages/ts-interface-generator/tsconfig-testcontrol.json | Adds explicit types: ["openui5"] to stabilize TS6 default type inclusion. |
| packages/ts-interface-generator/src/test/testcases/tsconfig-path-relative/tsconfig.json | Adds explicit types: ["openui5"] in testcase config. |
| packages/ts-interface-generator/src/test/testcases/testcaseRunner.test.ts | Extends the in-test CompilerOptions with types: ["openui5"]. |
| packages/ts-interface-generator/package.json | Bumps local TypeScript devDependency to 6.0.3. |
| packages/dts-generator/tsconfig.json | Adds explicit types, rootDir, strict, skipLibCheck for TS6 compatibility and clearer build configuration. |
| packages/dts-generator/tsconfig-test-apis.json | New dedicated project config used by test:apis to type-check specific .d.ts files under TS6. |
| packages/dts-generator/src/runCheck.ts | Switches compile-check module resolution from deprecated NodeJs to Node16. |
| packages/dts-generator/src/checkCompile/check-compile.ts | Updates documentation comment to reference ModuleResolutionKind.Node16. |
| packages/dts-generator/package.json | Bumps TypeScript to 6.0.3 and updates test:apis to use the dedicated tsconfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensures the build works outside hoisted monorepo setups now that tsconfig.json explicitly lists "types": ["node"].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general not affecting consumers, they can remain on TS 5.x. But:
BREAKING CHANGE: The re-exported ModuleResolutionKind enum no longer includes the deprecated NodeJs value. Consumers using ModuleResolutionKind.NodeJs must switch to Node16. The runCheck CLI now uses Node16 module resolution instead of Node10, which enforces file extensions and respects package.json exports.
Adapt all tsconfigs for TS6 changed defaults: