Conversation
TypeScript 6 requires module to be set to Node16 when moduleResolution is Node16. The previous ES2015 value was valid in TS5 but now causes a config diagnostic that cascades into spurious type errors (JQuery namespace, QUnit.Assert) during the check-compile phase.
There was a problem hiding this comment.
Pull request overview
Updates the dts-generator’s check-compile configuration to satisfy TypeScript 6’s requirement that compilerOptions.module is compatible with moduleResolution: Node16, preventing config diagnostics that previously cascaded into unrelated type errors during the check phase.
Changes:
- Set
tsOptions.moduletoModuleKind.Node16whenmoduleResolutionisNode16in the run-check CLI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 6 requires module to be set to Node16 when moduleResolution is Node16. The previous ES2015 value was valid in TS5 but now causes a config diagnostic that cascades into spurious type errors (JQuery namespace, QUnit.Assert) during the check-compile phase.