Skip to content

fix(dts-generator): add @types discovery to generate check-compile path#583

Merged
akudev merged 1 commit into
mainfrom
fix/THREE
May 29, 2026
Merged

fix(dts-generator): add @types discovery to generate check-compile path#583
akudev merged 1 commit into
mainfrom
fix/THREE

Conversation

@akudev
Copy link
Copy Markdown
Member

@akudev akudev commented May 29, 2026

TS6 no longer auto-includes @types packages when the compiler is invoked programmatically. The previous fix (631f1de) only addressed runCheck.ts but the generation path in generate.ts has the same problem — causing "Cannot find namespace 'THREE'" errors for sap.ui.vk in the legacy-free build.

Extracted the @types discovery logic into a shared utility (utils/discover-types.ts) and applied it to both generate.ts and runCheck.ts. Also aligned generate.ts module settings to ESNext + Bundler to prevent bare-specifier rejection of ambient declare module declarations.

@akudev akudev requested a review from codeworrior May 29, 2026 14:08
TS6 no longer auto-includes @types packages when the compiler is invoked
programmatically. The previous fix (631f1de) only addressed runCheck.ts
but the generation path in generate.ts has the same problem — causing
"Cannot find namespace 'THREE'" errors for sap.ui.vk in the legacy-free
build.

Extracted the @types discovery logic into a shared utility
(utils/discover-types.ts) and applied it to both generate.ts and
runCheck.ts. Also aligned generate.ts module settings to ESNext +
Bundler to prevent bare-specifier rejection of ambient declare module
declarations.
@akudev akudev merged commit fe0da50 into main May 29, 2026
6 checks passed
@akudev akudev deleted the fix/THREE branch May 29, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants