Skip to content

Conversation

@MarcusNotheis
Copy link
Contributor

BREAKING CHANGE: replaced prop selectedRowKey with selectedRowIds (Object of rowIds)
BREAKING CHANGE: Update to react-table 7.0.0-rc.10

Support Multi Selection of rows
BREAKING CHANGE: replaced prop `selectedRowKey` with `selectedRowIds` (Object of rowIds)
BREAKING CHANGE:  Update to react-table `7.0.0-rc.10`
@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit e30a36b

https://deploy-preview-253--ui5-webcomponents-react.netlify.com

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #253 into master will increase coverage by 0.98%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   72.48%   73.46%   +0.98%     
==========================================
  Files         162      160       -2     
  Lines        3558     3494      -64     
  Branches      618      603      -15     
==========================================
- Hits         2579     2567      -12     
+ Misses        769      721      -48     
+ Partials      210      206       -4
Impacted Files Coverage Δ
...mponents/AnalyticalTable/defaults/Column/index.tsx 75% <ø> (+15%) ⬆️
...AnalyticalTable/virtualization/VirtualTableRow.tsx 63.63% <0%> (ø) ⬆️
...onents/AnalyticalTable/hooks/useToggleRowExpand.ts 46.15% <100%> (ø) ⬆️
...nents/AnalyticalTable/tableReducer/stateReducer.ts 100% <100%> (ø) ⬆️
...nents/AnalyticalTable/hooks/useTableCellStyling.ts 40% <100%> (ø) ⬆️
...omponents/AnalyticalTable/hooks/useTableStyling.ts 100% <100%> (ø) ⬆️
...nalyticalTable/virtualization/VirtualTableBody.tsx 83.33% <100%> (+1.51%) ⬆️
...nts/AnalyticalTable/hooks/useTableHeaderStyling.ts 100% <100%> (ø) ⬆️
...nts/AnalyticalTable/defaults/Column/Aggregated.tsx 100% <100%> (ø)
...ages/main/src/components/AnalyticalTable/index.tsx 78.57% <100%> (+1.75%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2bc4c5...e30a36b. Read the comment docs.

@Lukas742 Lukas742 self-requested a review December 18, 2019 08:00
@MarcusNotheis MarcusNotheis merged commit e24561c into master Dec 18, 2019
@MarcusNotheis MarcusNotheis deleted the chore/update-react-table branch December 18, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants