Skip to content

fix(AnalyticalTable): don't select row when an actionable element was clicked #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2020
Merged

fix(AnalyticalTable): don't select row when an actionable element was clicked #432

merged 2 commits into from
Apr 16, 2020

Conversation

@MarcusNotheis
Copy link
Contributor

@MarcusNotheis MarcusNotheis commented Apr 16, 2020 •
edited
Loading

Closes #428

@MarcusNotheis
Copy link
Contributor Author

MarcusNotheis commented Apr 16, 2020

This solution feels very cumbersome but I didn't find a better way of checking if the source element is actionable or not. Maybe UI5/webcomponents#1489 can help here in future.

@github-actions
Copy link

github-actions bot commented Apr 16, 2020

Coverage Status

Coverage decreased (-0.05%) to 67.595% when pulling fcd4bfa on fix/analytical-table-clickable-elements into 5a4a083 on master.

@github-actions
Copy link

github-actions bot commented Apr 16, 2020 •
edited
Loading

Size Change: +428 B (0%)

Total Size: 229 kB

Filename Size Change
packages/main/lib/AnalyticalTable.js 16.1 kB +428 B (2%)
ℹ️ View Unchanged
Filename Size Change
packages/base/lib/createComponentStyles.js 206 B 0 B
packages/base/lib/CssSizeVariables.js 1.16 kB 0 B
packages/base/lib/Device.js 7.28 kB 0 B
packages/base/lib/Event.js 966 B 0 B
packages/base/lib/font72.js 447 B 0 B
packages/base/lib/HSLColor.js 2.87 kB 0 B
packages/base/lib/Logger.js 1.41 kB 0 B
packages/base/lib/Optional.js 1.48 kB 0 B
packages/base/lib/sap_fiori_3.js 6.69 kB 0 B
packages/base/lib/ScrollContext.js 232 B 0 B
packages/base/lib/Scroller.js 3.31 kB 0 B
packages/base/lib/ScrollLink.js 601 B 0 B
packages/base/lib/spacing.js 1.23 kB 0 B
packages/base/lib/StyleClassHelper.js 1.62 kB 0 B
packages/base/lib/ThemingParameters.js 3.4 kB 0 B
packages/base/lib/useConsolidatedRef.js 271 B 0 B
packages/base/lib/usePassThroughHtmlProps.js 765 B 0 B
packages/base/lib/useScrollElement.js 727 B 0 B
packages/base/lib/useViewportRange.js 1.07 kB 0 B
packages/base/lib/Utils.js 1.12 kB 0 B
packages/charts/lib/BarChart.js 4.65 kB 0 B
packages/charts/lib/BarChartPlaceholder.js 416 B 0 B
packages/charts/lib/ColumnChart.js 4.78 kB 0 B
packages/charts/lib/ColumnChartPlaceholder.js 452 B 0 B
packages/charts/lib/DonutChart.js 3.13 kB 0 B
packages/charts/lib/initialize.js 1.84 kB 0 B
packages/charts/lib/LineChart.js 4.3 kB 0 B
packages/charts/lib/LineChartPlaceholder.js 463 B 0 B
packages/charts/lib/MicroBarChart.js 2.63 kB 0 B
packages/charts/lib/next/BarChart.js 5.41 kB 0 B
packages/charts/lib/next/ChartContainer.js 672 B 0 B
packages/charts/lib/next/ColumnChart.js 5.5 kB 0 B
packages/charts/lib/next/ComposedChart.js 6.58 kB 0 B
packages/charts/lib/next/DonutChart.js 1.99 kB 0 B
packages/charts/lib/next/LineChart.js 5.43 kB 0 B
packages/charts/lib/next/MicroBarChart.js 1.95 kB 0 B
packages/charts/lib/next/PieChart.js 1.86 kB 0 B
packages/charts/lib/next/RadarChart.js 4.07 kB 0 B
packages/charts/lib/next/RadialChart.js 1.2 kB 0 B
packages/charts/lib/PieChart.js 3.09 kB 0 B
packages/charts/lib/PieChartPlaceholder.js 376 B 0 B
packages/charts/lib/RadarChart.js 2.83 kB 0 B
packages/charts/lib/RadialChart.js 3.68 kB 0 B
packages/charts/lib/useLegendItemClick.js 391 B 0 B
packages/charts/lib/useResolveDataKeys.js 294 B 0 B
packages/charts/lib/withChartContainer.js 2.88 kB 0 B
packages/main/lib/ActionSheet.js 1.24 kB 0 B
packages/main/lib/AnalyticalCard.js 1.21 kB 0 B
packages/main/lib/AnalyticalCardHeader.js 2.94 kB 0 B
packages/main/lib/AnalyticalTableScrollMode.js 185 B 0 B
packages/main/lib/Avatar.js 440 B 0 B
packages/main/lib/AvatarBackgroundColor.js 219 B 0 B
packages/main/lib/AvatarFitType.js 151 B 0 B
packages/main/lib/AvatarShape.js 150 B 0 B
packages/main/lib/AvatarSize.js 155 B 0 B
packages/main/lib/Badge.js 320 B 0 B
packages/main/lib/Bar.js 1.33 kB 0 B
packages/main/lib/BarDesign.js 177 B 0 B
packages/main/lib/Breadcrumbs.js 722 B 0 B
packages/main/lib/BreadcrumbsSeparatorStyle.js 198 B 0 B
packages/main/lib/BusyIndicator.js 350 B 0 B
packages/main/lib/BusyIndicatorSize.js 167 B 0 B
packages/main/lib/Button.js 376 B 0 B
packages/main/lib/ButtonDesign.js 190 B 0 B
packages/main/lib/Calendar.js 362 B 0 B
packages/main/lib/CalendarType.js 212 B 0 B
packages/main/lib/Card.js 358 B 0 B
packages/main/lib/Carousel.js 402 B 0 B
packages/main/lib/CarouselArrowsPlacement.js 166 B 0 B
packages/main/lib/CheckBox.js 398 B 0 B
packages/main/lib/ComboBox.js 439 B 0 B
packages/main/lib/ComboBoxItem.js 318 B 0 B
packages/main/lib/ContentDensity.js 151 B 0 B
packages/main/lib/CurrentViewportRangeContext.js 133 B 0 B
packages/main/lib/CustomListItem.js 355 B 0 B
packages/main/lib/DatePicker.js 481 B 0 B
packages/main/lib/DeviationIndicator.js 160 B 0 B
packages/main/lib/Dialog.js 376 B 0 B
packages/main/lib/FileUploader.js 418 B 0 B
packages/main/lib/FilterBar.js 2.02 kB 0 B
packages/main/lib/FilterItem.js 1.55 kB 0 B
packages/main/lib/FilterType.js 170 B 0 B
packages/main/lib/FlexBox.js 1.09 kB 0 B
packages/main/lib/FlexBoxAlignItems.js 189 B 0 B
packages/main/lib/FlexBoxDirection.js 169 B 0 B
packages/main/lib/FlexBoxJustifyContent.js 194 B 0 B
packages/main/lib/FlexBoxWrap.js 154 B 0 B
packages/main/lib/Form.js 1.75 kB 0 B
packages/main/lib/FormGroup.js 559 B 0 B
packages/main/lib/FormItem.js 1.55 kB 0 B
packages/main/lib/GlobalStyleClasses.js 151 B 0 B
packages/main/lib/Grid.js 3.73 kB 0 B
packages/main/lib/GridPosition.js 157 B 0 B
packages/main/lib/GroupHeaderListItem.js 333 B 0 B
packages/main/lib/Icon.js 337 B 0 B
packages/main/lib/Input.js 479 B 0 B
packages/main/lib/InputType.js 184 B 0 B
packages/main/lib/Label.js 348 B 0 B
packages/main/lib/Link.js 368 B 0 B
packages/main/lib/LinkDesign.js 191 B 0 B
packages/main/lib/List.js 455 B 0 B
packages/main/lib/ListItemTypes.js 160 B 0 B
packages/main/lib/ListMode.js 191 B 0 B
packages/main/lib/ListSeparators.js 186 B 0 B
packages/main/lib/Loader.js 2.18 kB 0 B
packages/main/lib/LoaderType.js 152 B 0 B
packages/main/lib/MessageBox.js 1.99 kB 0 B
packages/main/lib/MessageBoxActions.js 231 B 0 B
packages/main/lib/MessageBoxTypes.js 232 B 0 B
packages/main/lib/MessageStrip.js 379 B 0 B
packages/main/lib/MessageStripType.js 181 B 0 B
packages/main/lib/MultiComboBox.js 449 B 0 B
packages/main/lib/MultiComboBoxItem.js 337 B 0 B
packages/main/lib/Notification.js 4.25 kB 0 B
packages/main/lib/NotificationGroup.js 321 B 0 B
packages/main/lib/ObjectPage.js 10.1 kB 0 B
packages/main/lib/ObjectPageMode.js 159 B 0 B
packages/main/lib/ObjectPageSection.js 2.2 kB 0 B
packages/main/lib/ObjectPageSubSection.js 2.04 kB 0 B
packages/main/lib/ObjectStatus.js 1.2 kB 0 B
packages/main/lib/Option.js 324 B 0 B
packages/main/lib/Page.js 2.03 kB 0 B
packages/main/lib/PageBackgroundDesign.js 183 B 0 B
packages/main/lib/Panel.js 376 B 0 B
packages/main/lib/PanelAccessibleRoles.js 201 B 0 B
packages/main/lib/PlacementType.js 175 B 0 B
packages/main/lib/Popover.js 495 B 0 B
packages/main/lib/PopoverHorizontalAlign.js 181 B 0 B
packages/main/lib/PopoverPlacementType.js 172 B 0 B
packages/main/lib/PopoverVerticalAlign.js 204 B 0 B
packages/main/lib/Priority.js 163 B 0 B
packages/main/lib/ProductSwitch.js 308 B 0 B
packages/main/lib/ProductSwitchItem.js 379 B 0 B
packages/main/lib/ProgressIndicator.js 1.79 kB 0 B
packages/main/lib/RadioButton.js 406 B 0 B
packages/main/lib/ResponsivePopover.js 510 B 0 B
packages/main/lib/SegmentedButton.js 321 B 0 B
packages/main/lib/Select.js 358 B 0 B
packages/main/lib/SemanticColor.js 181 B 0 B
packages/main/lib/ShellBar.js 465 B 0 B
packages/main/lib/ShellBarItem.js 342 B 0 B
packages/main/lib/SideNavigation.js 2.06 kB 0 B
packages/main/lib/SideNavigationListItem.js 3.05 kB 0 B
packages/main/lib/SideNavigationOpenState.js 174 B 0 B
packages/main/lib/Size.js 151 B 0 B
packages/main/lib/Spinner.js 1.75 kB 0 B
packages/main/lib/StandardListItem.js 388 B 0 B
packages/main/lib/SuggestionItem.js 367 B 0 B
packages/main/lib/Switch.js 359 B 0 B
packages/main/lib/Tab.js 385 B 0 B
packages/main/lib/TabContainer.js 383 B 0 B
packages/main/lib/TabLayout.js 150 B 0 B
packages/main/lib/Table.js 370 B 0 B
packages/main/lib/TableCell.js 303 B 0 B
packages/main/lib/TableColumn.js 341 B 0 B
packages/main/lib/TablePlaceholder.js 1.12 kB 0 B
packages/main/lib/TableRow.js 302 B 0 B
packages/main/lib/TableScaleWidthMode.js 169 B 0 B
packages/main/lib/TableSelectionBehavior.js 178 B 0 B
packages/main/lib/TableSelectionMode.js 182 B 0 B
packages/main/lib/TabSeparator.js 306 B 0 B
packages/main/lib/Text.js 846 B 0 B
packages/main/lib/TextAlign.js 183 B 0 B
packages/main/lib/TextArea.js 448 B 0 B
packages/main/lib/ThemeProvider.js 5.46 kB 0 B
packages/main/lib/Themes.js 178 B 0 B
packages/main/lib/ThemingSupport.js 9.21 kB 0 B
packages/main/lib/Timeline.js 298 B 0 B
packages/main/lib/TimelineItem.js 370 B 0 B
packages/main/lib/TimePicker.js 418 B 0 B
packages/main/lib/Title.js 337 B 0 B
packages/main/lib/TitleLevel.js 163 B 0 B
packages/main/lib/Toast.js 349 B 0 B
packages/main/lib/ToastPlacement.js 208 B 0 B
packages/main/lib/ToggleButton.js 397 B 0 B
packages/main/lib/Token.js 233 B 0 B
packages/main/lib/Tokenizer.js 248 B 0 B
packages/main/lib/ValueState.js 182 B 0 B
packages/main/lib/VariantManagement.js 2.78 kB 0 B
packages/main/lib/VerticalAlign.js 174 B 0 B
packages/main/lib/withWebComponent.js 2.58 kB 0 B

compressed-size-action

@MarcusNotheis MarcusNotheis merged commit 8c31818 into master Apr 16, 2020
@MarcusNotheis MarcusNotheis deleted the fix/analytical-table-clickable-elements branch April 16, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

+1 more reviewer

@vbersch vbersch vbersch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analytical Table: Unable to click components inside cells

4 participants

@MarcusNotheis @vbersch @Lukas742