Skip to content

fix: use createPortal for all internal popovers #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarcusNotheis merged 7 commits into from
Aug 3, 2020
Merged

fix: use createPortal for all internal popovers #636

MarcusNotheis merged 7 commits into from
Aug 3, 2020

Conversation

@MarcusNotheis
Copy link
Contributor

@MarcusNotheis MarcusNotheis commented Aug 3, 2020

By using createPortal for all internal popovers we allow users to render e.g. an AnalyticalTable as Dialog content and still be able to open popovers in the correct position.

@MarcusNotheis MarcusNotheis requested review from Lukas742 and vbersch and removed request for Lukas742 August 3, 2020 09:56
@github-actions
Copy link

github-actions bot commented Aug 3, 2020 •
edited
Loading

Size Change: +65 B (0%)

Total Size: 157 kB

Filename Size Change
packages/main/lib/ActionSheet.js 1.24 kB -17 B (1%)
packages/main/lib/AnalyticalTable.js 16.4 kB +24 B (0%)
packages/main/lib/ObjectPage.js 9.17 kB +28 B (0%)
packages/main/lib/VariantManagement.js 2.01 kB +30 B (1%)
ℹ️ View Unchanged
Filename Size Change
packages/base/lib/createComponentStyles.js 206 B 0 B
packages/base/lib/CssSizeVariables.js 918 B 0 B
packages/base/lib/Device.js 6.47 kB 0 B
packages/base/lib/hooks.js 1.38 kB 0 B
packages/base/lib/Logger.js 1.2 kB 0 B
packages/base/lib/spacing.js 997 B 0 B
packages/base/lib/StyleClassHelper.js 610 B 0 B
packages/base/lib/ThemingParameters.js 3.4 kB 0 B
packages/base/lib/useConsolidatedRef.js 271 B 0 B
packages/base/lib/usePassThroughHtmlProps.js 318 B 0 B
packages/base/lib/useViewportRange.js 460 B 0 B
packages/base/lib/Utils.js 775 B 0 B
packages/charts/lib/BarChart.js 3.83 kB 0 B
packages/charts/lib/BarChartPlaceholder.js 456 B 0 B
packages/charts/lib/ColumnChart.js 4.06 kB 0 B
packages/charts/lib/ColumnChartPlaceholder.js 514 B 0 B
packages/charts/lib/components/ChartContainer.js 880 B 0 B
packages/charts/lib/components/ChartDataLabel.js 605 B 0 B
packages/charts/lib/components/ComposedChartPlaceholder.js 878 B 0 B
packages/charts/lib/components/XAxisTicks.js 596 B 0 B
packages/charts/lib/components/YAxisTicks.js 513 B 0 B
packages/charts/lib/ComposedChart.js 4.79 kB 0 B
packages/charts/lib/DonutChart.js 2.05 kB 0 B
packages/charts/lib/LineChart.js 3.94 kB 0 B
packages/charts/lib/LineChartPlaceholder.js 529 B 0 B
packages/charts/lib/MicroBarChart.js 1.9 kB 0 B
packages/charts/lib/PieChart.js 1.97 kB 0 B
packages/charts/lib/PieChartPlaceholder.js 445 B 0 B
packages/charts/lib/RadarChart.js 2.04 kB 0 B
packages/charts/lib/RadialChart.js 1.11 kB 0 B
packages/charts/lib/ScatterChart.js 3.59 kB 0 B
packages/charts/lib/ScatterChartPlaceholder.js 535 B 0 B
packages/charts/lib/useLegendItemClick.js 391 B 0 B
packages/charts/lib/Utils.js 534 B 0 B
packages/main/lib/AnalyticalCard.js 776 B 0 B
packages/main/lib/AnalyticalCardHeader.js 2.72 kB 0 B
packages/main/lib/AnalyticalTableScrollMode.js 177 B 0 B
packages/main/lib/Avatar.js 438 B 0 B
packages/main/lib/AvatarBackgroundColor.js 219 B 0 B
packages/main/lib/AvatarFitType.js 151 B 0 B
packages/main/lib/AvatarShape.js 150 B 0 B
packages/main/lib/AvatarSize.js 155 B 0 B
packages/main/lib/Badge.js 320 B 0 B
packages/main/lib/Bar.js 1.3 kB 0 B
packages/main/lib/BarDesign.js 177 B 0 B
packages/main/lib/Breadcrumbs.js 740 B 0 B
packages/main/lib/BreadcrumbsSeparatorStyle.js 198 B 0 B
packages/main/lib/BusyIndicator.js 357 B 0 B
packages/main/lib/BusyIndicatorSize.js 167 B 0 B
packages/main/lib/Button.js 370 B 0 B
packages/main/lib/ButtonDesign.js 190 B 0 B
packages/main/lib/Calendar.js 372 B 0 B
packages/main/lib/CalendarType.js 212 B 0 B
packages/main/lib/Card.js 347 B 0 B
packages/main/lib/Carousel.js 449 B 0 B
packages/main/lib/CarouselArrowsPlacement.js 166 B 0 B
packages/main/lib/CheckBox.js 388 B 0 B
packages/main/lib/ComboBox.js 431 B 0 B
packages/main/lib/ComboBoxItem.js 311 B 0 B
packages/main/lib/ContentDensity.js 151 B 0 B
packages/main/lib/CustomListItem.js 361 B 0 B
packages/main/lib/DatePicker.js 483 B 0 B
packages/main/lib/DateRangePicker.js 504 B 0 B
packages/main/lib/DateTimePicker.js 490 B 0 B
packages/main/lib/DeviationIndicator.js 160 B 0 B
packages/main/lib/Dialog.js 384 B 0 B
packages/main/lib/DurationPicker.js 453 B 0 B
packages/main/lib/FCLLayout.js 236 B 0 B
packages/main/lib/FileUploader.js 401 B 0 B
packages/main/lib/FilterBar.js 6.19 kB 0 B
packages/main/lib/FilterGroupItem.js 1.21 kB 0 B
packages/main/lib/FilterItem.js 1.65 kB 0 B
packages/main/lib/FilterType.js 170 B 0 B
packages/main/lib/FlexBox.js 994 B 0 B
packages/main/lib/FlexBoxAlignItems.js 189 B 0 B
packages/main/lib/FlexBoxDirection.js 169 B 0 B
packages/main/lib/FlexBoxJustifyContent.js 194 B 0 B
packages/main/lib/FlexBoxWrap.js 154 B 0 B
packages/main/lib/FlexibleColumnLayout.js 386 B 0 B
packages/main/lib/Form.js 2.48 kB 0 B
packages/main/lib/FormGroup.js 425 B 0 B
packages/main/lib/FormItem.js 752 B 0 B
packages/main/lib/GlobalStyleClasses.js 151 B 0 B
packages/main/lib/Grid.js 1.6 kB 0 B
packages/main/lib/GridPosition.js 157 B 0 B
packages/main/lib/GroupHeaderListItem.js 333 B 0 B
packages/main/lib/Icon.js 342 B 0 B
packages/main/lib/Input.js 491 B 0 B
packages/main/lib/InputType.js 184 B 0 B
packages/main/lib/Label.js 341 B 0 B
packages/main/lib/Link.js 359 B 0 B
packages/main/lib/LinkDesign.js 191 B 0 B
packages/main/lib/List.js 451 B 0 B
packages/main/lib/ListItemTypes.js 160 B 0 B
packages/main/lib/ListMode.js 191 B 0 B
packages/main/lib/ListSeparators.js 186 B 0 B
packages/main/lib/Loader.js 1.32 kB 0 B
packages/main/lib/LoaderType.js 152 B 0 B
packages/main/lib/MessageBox.js 2.3 kB 0 B
packages/main/lib/MessageBoxActions.js 231 B 0 B
packages/main/lib/MessageBoxTypes.js 232 B 0 B
packages/main/lib/MessageStrip.js 371 B 0 B
packages/main/lib/MessageStripType.js 181 B 0 B
packages/main/lib/MultiComboBox.js 439 B 0 B
packages/main/lib/MultiComboBoxItem.js 330 B 0 B
packages/main/lib/NotificationListGroupItem.js 434 B 0 B
packages/main/lib/NotificationListItem.js 426 B 0 B
packages/main/lib/NotificationOverflowAction.js 332 B 0 B
packages/main/lib/ObjectPageMode.js 159 B 0 B
packages/main/lib/ObjectPageSection.js 1.27 kB 0 B
packages/main/lib/ObjectPageSubSection.js 1.11 kB 0 B
packages/main/lib/ObjectStatus.js 1.22 kB 0 B
packages/main/lib/Option.js 324 B 0 B
packages/main/lib/Page.js 2.05 kB 0 B
packages/main/lib/PageBackgroundDesign.js 183 B 0 B
packages/main/lib/Panel.js 399 B 0 B
packages/main/lib/PanelAccessibleRoles.js 201 B 0 B
packages/main/lib/PlacementType.js 175 B 0 B
packages/main/lib/Popover.js 506 B 0 B
packages/main/lib/PopoverHorizontalAlign.js 181 B 0 B
packages/main/lib/PopoverPlacementType.js 172 B 0 B
packages/main/lib/PopoverVerticalAlign.js 204 B 0 B
packages/main/lib/Priority.js 163 B 0 B
packages/main/lib/ProductSwitch.js 308 B 0 B
packages/main/lib/ProductSwitchItem.js 359 B 0 B
packages/main/lib/ProgressIndicator.js 379 B 0 B
packages/main/lib/RadioButton.js 397 B 0 B
packages/main/lib/RatingIndicator.js 366 B 0 B
packages/main/lib/ResponsivePopover.js 519 B 0 B
packages/main/lib/SegmentedButton.js 321 B 0 B
packages/main/lib/Select.js 352 B 0 B
packages/main/lib/SemanticColor.js 181 B 0 B
packages/main/lib/ShellBar.js 456 B 0 B
packages/main/lib/ShellBarItem.js 346 B 0 B
packages/main/lib/SideNavigation.js 350 B 0 B
packages/main/lib/SideNavigationItem.js 356 B 0 B
packages/main/lib/SideNavigationSubItem.js 351 B 0 B
packages/main/lib/Size.js 151 B 0 B
packages/main/lib/Spinner.js 1.22 kB 0 B
packages/main/lib/StandardListItem.js 427 B 0 B
packages/main/lib/SuggestionItem.js 416 B 0 B
packages/main/lib/Switch.js 351 B 0 B
packages/main/lib/Tab.js 380 B 0 B
packages/main/lib/TabContainer.js 413 B 0 B
packages/main/lib/TabContainerTabsPlacement.js 161 B 0 B
packages/main/lib/TabLayout.js 150 B 0 B
packages/main/lib/Table.js 366 B 0 B
packages/main/lib/TableCell.js 303 B 0 B
packages/main/lib/TableColumn.js 352 B 0 B
packages/main/lib/TablePlaceholder.js 771 B 0 B
packages/main/lib/TableRow.js 302 B 0 B
packages/main/lib/TableScaleWidthMode.js 169 B 0 B
packages/main/lib/TableSelectionBehavior.js 178 B 0 B
packages/main/lib/TableSelectionMode.js 182 B 0 B
packages/main/lib/TabSeparator.js 306 B 0 B
packages/main/lib/Text.js 827 B 0 B
packages/main/lib/TextAlign.js 183 B 0 B
packages/main/lib/TextArea.js 469 B 0 B
packages/main/lib/ThemeProvider.js 1.1 kB 0 B
packages/main/lib/Themes.js 178 B 0 B
packages/main/lib/Timeline.js 298 B 0 B
packages/main/lib/TimelineItem.js 357 B 0 B
packages/main/lib/TimePicker.js 419 B 0 B
packages/main/lib/Title.js 337 B 0 B
packages/main/lib/TitleLevel.js 163 B 0 B
packages/main/lib/Toast.js 349 B 0 B
packages/main/lib/ToastPlacement.js 208 B 0 B
packages/main/lib/ToggleButton.js 391 B 0 B
packages/main/lib/Token.js 233 B 0 B
packages/main/lib/Tokenizer.js 248 B 0 B
packages/main/lib/Toolbar.js 3 kB 0 B
packages/main/lib/ToolbarDesign.js 175 B 0 B
packages/main/lib/ToolbarSeparator.js 477 B 0 B
packages/main/lib/ToolbarSpacer.js 220 B 0 B
packages/main/lib/ToolbarStyle.js 153 B 0 B
packages/main/lib/Tree.js 381 B 0 B
packages/main/lib/TreeItem.js 355 B 0 B
packages/main/lib/UploadCollection.js 400 B 0 B
packages/main/lib/UploadCollectionItem.js 456 B 0 B
packages/main/lib/UploadState.js 170 B 0 B
packages/main/lib/ValueState.js 182 B 0 B
packages/main/lib/VerticalAlign.js 174 B 0 B
packages/main/lib/withWebComponent.js 1.58 kB 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Aug 3, 2020

Coverage Status

Coverage decreased (-0.04%) to 65.884% when pulling 5c17b46 on fix/use-portal-for-popovers into a5737c3 on master.

@MarcusNotheis MarcusNotheis merged commit 9b36161 into master Aug 3, 2020
@MarcusNotheis MarcusNotheis deleted the fix/use-portal-for-popovers branch August 3, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

@vbersch vbersch Awaiting requested review from vbersch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcusNotheis @coveralls @Lukas742