Skip to content

fix(AnalyticalTable - TypeScript): improve callback types #7858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix(AnalyticalTable - TypeScript): improve callback types #7858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/main/src/components/AnalyticalTable/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,12 +976,12 @@ export interface AnalyticalTablePropTypes extends Omit<CommonProps, 'title'> {
/**
* Fired when the grouping of the rows changes.
*/
onGroup?: (e: CustomEvent<{ column: ColumnType; groupedColumns: string[] }>) => void;
onGroup?: (e: CustomEvent<{ column: ColumnType; groupedColumns: string[]; isGrouped: boolean }>) => void;
/**
* Fired when a row is selected or unselected.
*/
onRowSelect?: (
e?: CustomEvent<{
e: CustomEvent<{
/**
* Selected row object.
*
Expand All @@ -1007,11 +1007,11 @@ export interface AnalyticalTablePropTypes extends Omit<CommonProps, 'title'> {
/**
* Fired when a row is expanded or collapsed
*/
onRowExpandChange?: (e?: CustomEvent<{ row: unknown; column: unknown }>) => void;
onRowExpandChange?: (e: CustomEvent<{ row: unknown; column: unknown }>) => void;
/**
* Fired when the columns order is changed.
*/
onColumnsReorder?: (e?: CustomEvent<{ columnsNewOrder: string[]; column: unknown }>) => void;
onColumnsReorder?: (e: CustomEvent<{ columnsNewOrder: ColumnType[]; column: ColumnType }>) => void;
/**
* Fired when the `infiniteScrollThreshold` is reached.
*
Expand All @@ -1021,21 +1021,21 @@ export interface AnalyticalTablePropTypes extends Omit<CommonProps, 'title'> {
* @param {number} e.detail.rowCount - The number of rows
* @param {number} e.detail.totalRowCount - The total number of rows, including sub-rows
*/
onLoadMore?: (e?: CustomEvent<{ rowCount: number; totalRowCount: number }>) => void;
onLoadMore?: (e: CustomEvent<{ rowCount: number; totalRowCount: number }>) => void;
/**
* Fired when the body of the table is scrolled.
*
* __Note:__ This callback __must be memoized__! Since it is triggered on __every scroll event__,
* non-memoized or expensive calculations can have a __huge impact on performance__ and cause visible lag.
* Throttling or debouncing is always recommended to reduce performance overhead.
*/
onTableScroll?: (e?: CustomEvent<{ rows: Record<string, any>[]; rowElements: HTMLCollection }>) => void;
onTableScroll?: (e: CustomEvent<{ rows: Record<string, any>[]; rowElements: HTMLCollection }>) => void;
/**
* Fired when the table is resized by double-clicking the Resizer.
*
* __Note:__ Auto-resize is only available on columns that have the `autoResizable` option set to `true`.
*/
onAutoResize?: (e?: OnAutoResizeMouseEvent) => void;
onAutoResize?: (e: OnAutoResizeMouseEvent) => void;
/**
* Fired when a filter is applied to a column.
*/
Expand Down
Loading