feat(ColumnChart): add alignLabels property#8534
Conversation
There was a problem hiding this comment.
Hi @skythefire
thanks a lot for the contribution! Please see my review below.
BarCharthardcodes'insideRight'the same way. Both are independent wrappers around recharts'BarChart(no shared base). Please addalignLabelstoBarChartas well (default'insideRight').BulletChartandComposedChartalso use theChartDataLabelcomponent. Due to the type change a typescript error is now thrown. Please adjust the types forlabelPositionin these components as well. You can check if there are build errors locally by runningyarn build.
|
@Lukas742 Thanks for the review, I've addressed your comments accordingly |
Lukas742
left a comment
There was a problem hiding this comment.
Looks good to me! 🚢
Please note that I adjusted the ChartDataLabel to filter out non-Label props. I hope that's alright :)
We will merge this PR soon and include it in our next minor release.
Looks great, I realise that I misunderstood your previous comments, so all's good! |
Coverage Report for CI Build 25482025905Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.003%) to 84.141%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
|
🎉 This PR is included in version v2.22.0 🎉 The release is available on v2.22.0 Your semantic-release bot 📦🚀 |
Fixes: #3421
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist