Skip to content

feat(ColumnChart): add alignLabels property#8534

Merged
Lukas742 merged 8 commits into
UI5:mainfrom
skythefire:feat/column-charts-add-alignLabels
May 11, 2026
Merged

feat(ColumnChart): add alignLabels property#8534
Lukas742 merged 8 commits into
UI5:mainfrom
skythefire:feat/column-charts-add-alignLabels

Conversation

@skythefire
Copy link
Copy Markdown
Contributor

@skythefire skythefire commented Apr 30, 2026

Fixes: #3421

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@skythefire skythefire marked this pull request as ready for review April 30, 2026 08:47
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Apr 30, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@Lukas742 Lukas742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skythefire

thanks a lot for the contribution! Please see my review below.


  • BarChart hardcodes 'insideRight' the same way. Both are independent wrappers around recharts' BarChart (no shared base). Please add alignLabels to BarChart as well (default 'insideRight').
  • BulletChart and ComposedChart also use the ChartDataLabel component. Due to the type change a typescript error is now thrown. Please adjust the types for labelPosition in these components as well. You can check if there are build errors locally by running yarn build.

Comment thread packages/charts/src/components/ColumnChart/index.tsx Outdated
Comment thread packages/charts/src/components/ColumnChart/index.tsx Outdated
Comment thread packages/charts/src/components/ColumnChart/index.tsx Outdated
Comment thread packages/charts/src/components/ColumnChart/index.tsx Outdated
Comment thread packages/charts/src/internal/ChartDataLabel.tsx Outdated
Comment thread packages/charts/src/internal/ChartDataLabel.tsx Outdated
@skythefire
Copy link
Copy Markdown
Contributor Author

@Lukas742 Thanks for the review, I've addressed your comments accordingly

Copy link
Copy Markdown
Contributor

@Lukas742 Lukas742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚢

Please note that I adjusted the ChartDataLabel to filter out non-Label props. I hope that's alright :)

We will merge this PR soon and include it in our next minor release.

@skythefire
Copy link
Copy Markdown
Contributor Author

Looks good to me! 🚢

Please note that I adjusted the ChartDataLabel to filter out non-Label props. I hope that's alright :)

We will merge this PR soon and include it in our next minor release.

Looks great, I realise that I misunderstood your previous comments, so all's good!

@Lukas742 Lukas742 enabled auto-merge May 11, 2026 10:22
@Lukas742 Lukas742 added this pull request to the merge queue May 11, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25482025905

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.003%) to 84.141%

Details

  • Coverage increased (+0.003%) from the base build.
  • Patch coverage: 3 of 3 lines across 3 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 5841
Covered Lines: 5169
Line Coverage: 88.5%
Relevant Branches: 3403
Covered Branches: 2609
Branch Coverage: 76.67%
Branches in Coverage %: Yes
Coverage Strength: 104153.57 hits per line

💛 - Coveralls

Merged via the queue into UI5:main with commit 2ac663e May 11, 2026
25 checks passed
@ui5-webcomponents-react-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version v2.22.0 🎉

The release is available on v2.22.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stacked Charts: Label Alignment

4 participants