Skip to content

fix(AnalyticalTable): prevent subcomponent re-render loop at browser zoom #8645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 2 commits into from
May 28, 2026
+159 −111
Merged

fix(AnalyticalTable): prevent subcomponent re-render loop at browser zoom #8645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
663916a
fix(AnalyticalTable): prevent subcomponent re-render loop at fraction…
Lukas742 May 28, 2026
8f20742
Merge branch 'main' into fix/at-subcomponents-zoom
Lukas742 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
263 changes: 154 additions & 109 deletions packages/main/src/components/AnalyticalTable/AnalyticalTable.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2486,131 +2486,176 @@ describe('AnalyticalTable', () => {
cy.findByText('A').shouldNotBeClickable(done);
});

it('render subcomponents', () => {
const renderRowSubComponentLarge = (row) => {
return (
<div title="subcomponent" style={{ height: '200px', width: '100%', display: 'flex', alignItems: 'end' }}>
{`SubComponent ${row.index}`}
</div>
);
};
const renderRowSubComponent = () => {
return <div title="subcomponent">SubComponent</div>;
};
// `describe` is used to clean-up zoom level after test
describe('render subcomponents', () => {
let originalZoom: string;
before(() => {
originalZoom = document.documentElement.style.zoom;
});
after(() => {
document.documentElement.style.zoom = originalZoom;
});

const onlyFirstRowWithSubcomponent = (row) => {
if (row.id === '0') {
return <div title="subcomponent">SingleSubComponent</div>;
}
};
cy.mount(<AnalyticalTable data={data} columns={columns} renderRowSubComponent={renderRowSubComponent} />);
// ~700 callback invocations per mount at default zoom; broken fractional-zoom loop produces 5000+
const LOOP_BUDGET_PER_MOUNT = 2000;

cy.findAllByTitle('Expand Node').should('have.length', 4);
cy.findAllByTitle('Collapse Node').should('not.exist');
[
{ zoom: '1', label: 'default zoom' },
{ zoom: '1.1', label: 'fractional zoom (1.1)' },
].forEach(({ zoom, label }) => {
it(label, () => {
document.documentElement.style.zoom = zoom;

let renderCallCount = 0;
const countCalls = (fn) => (row) => {
renderCallCount++;
return fn(row);
};
const expectBoundedAndReset = () => {
cy.then(() => {
expect(renderCallCount).to.be.lessThan(LOOP_BUDGET_PER_MOUNT);
renderCallCount = 0;
});
};

cy.get('[aria-rowindex="2"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();
const renderRowSubComponentLarge = countCalls((row) => {
return (
<div title="subcomponent" style={{ height: '200px', width: '100%', display: 'flex', alignItems: 'end' }}>
{`SubComponent ${row.index}`}
</div>
);
});
const renderRowSubComponent = countCalls(() => {
return <div title="subcomponent">SubComponent</div>;
});
const onlyFirstRowWithSubcomponent = countCalls((row) => {
if (row.id === '0') {
return <div title="subcomponent">SingleSubComponent</div>;
}
});

cy.findAllByTitle('Expand Node').should('have.length', 3);
cy.findAllByTitle('Collapse Node').should('have.length', 1);
cy.findByText('SubComponent').should('be.visible');
cy.mount(<AnalyticalTable data={data} columns={columns} renderRowSubComponent={renderRowSubComponent} />);

cy.get('[aria-rowindex="3"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();
cy.findAllByTitle('Expand Node').should('have.length', 4);
cy.findAllByTitle('Collapse Node').should('not.exist');

cy.findAllByTitle('Expand Node').should('have.length', 2);
cy.findAllByTitle('Collapse Node').should('have.length', 2);
cy.findAllByText('SubComponent').should('be.visible').should('have.length', 2);
cy.get('[aria-rowindex="2"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();

cy.mount(<AnalyticalTable data={data} columns={columns} renderRowSubComponent={onlyFirstRowWithSubcomponent} />);
cy.findAllByTitle('Expand Node').should('have.length', 3);
cy.findAllByTitle('Collapse Node').should('have.length', 1);
cy.findByText('SubComponent').should('be.visible');

cy.findAllByTitle('Expand Node').should('have.length', 1);
cy.findAllByTitle('Collapse Node').should('not.exist');
cy.get('[aria-rowindex="3"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();

cy.get('[aria-rowindex="2"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();
cy.findAllByTitle('Expand Node').should('have.length', 2);
cy.findAllByTitle('Collapse Node').should('have.length', 2);
cy.findAllByText('SubComponent').should('be.visible').should('have.length', 2);
expectBoundedAndReset();

cy.findAllByTitle('Expand Node').should('not.exist');
cy.findAllByTitle('Collapse Node').should('have.length', 1);
cy.findByText('SingleSubComponent').should('be.visible');
cy.get('[aria-rowindex="3"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').should('not.exist');
cy.mount(
<AnalyticalTable data={data} columns={columns} renderRowSubComponent={onlyFirstRowWithSubcomponent} />,
);

cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponent}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.Visible}
/>,
);
cy.findAllByText('SubComponent').should('be.visible').should('have.length', 4);
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
cy.findAllByTitle('Expand Node').should('have.length', 1);
cy.findAllByTitle('Collapse Node').should('not.exist');

cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={onlyFirstRowWithSubcomponent}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.Visible}
/>,
);
cy.findByText('SingleSubComponent').should('be.visible').should('have.length', 1);
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
cy.get('[aria-rowindex="2"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();

cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponentLarge}
visibleRows={3}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.Visible}
/>,
);
cy.wait(300);
cy.findAllByTitle('Expand Node').should('not.exist');
cy.findAllByTitle('Collapse Node').should('have.length', 1);
cy.findByText('SingleSubComponent').should('be.visible');
cy.get('[aria-rowindex="3"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').should('not.exist');
expectBoundedAndReset();

cy.findByText('SubComponent 1').should('exist').and('not.be.visible');
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponent}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.Visible}
/>,
);
cy.findAllByText('SubComponent').should('be.visible').should('have.length', 4);
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
expectBoundedAndReset();

cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponentLarge}
visibleRows={3}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.IncludeHeight}
/>,
);
cy.findByText('SubComponent 1').should('be.visible');
cy.findByText('SubComponent 2').should('be.visible');
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={onlyFirstRowWithSubcomponent}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.Visible}
/>,
);
cy.findByText('SingleSubComponent').should('be.visible').should('have.length', 1);
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
expectBoundedAndReset();

const loadMore = cy.spy().as('more');
cy.mount(
<AnalyticalTable
onLoadMore={loadMore}
infiniteScroll={true}
infiniteScrollThreshold={0}
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponentLarge}
visibleRows={3}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.IncludeHeightExpandable}
/>,
);
cy.findByText('A').should('be.visible');
cy.findByText('X').should('be.visible');
cy.findByText('C').should('not.be.visible');
cy.get('[aria-rowindex="2"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();
cy.findByText('A').should('be.visible');
cy.findByText('X').should('be.visible');
cy.findByText('C').should('not.be.visible');
cy.get('[aria-rowindex="3"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();
cy.findByText('A').should('be.visible');
cy.findByText('X').should('be.visible');
cy.findByText('C').should('not.be.visible');
cy.get('[data-component-name="AnalyticalTableBody"]').scrollTo('bottom');
cy.get('@more').should('have.been.calledOnce');
cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponentLarge}
visibleRows={3}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.Visible}
/>,
);
cy.wait(300);

cy.findByText('SubComponent 1').should('exist').and('not.be.visible');
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
expectBoundedAndReset();

cy.mount(
<AnalyticalTable
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponentLarge}
visibleRows={3}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.IncludeHeight}
/>,
);
cy.findByText('SubComponent 1').should('be.visible');
cy.findByText('SubComponent 2').should('be.visible');
cy.findByTitle('Expand Node').should('not.exist');
cy.findByTitle('Collapse Node').should('not.exist');
expectBoundedAndReset();

const loadMore = cy.spy().as('more');
cy.mount(
<AnalyticalTable
onLoadMore={loadMore}
infiniteScroll={true}
infiniteScrollThreshold={0}
data={data}
columns={columns}
renderRowSubComponent={renderRowSubComponentLarge}
visibleRows={3}
subComponentsBehavior={AnalyticalTableSubComponentsBehavior.IncludeHeightExpandable}
/>,
);
cy.findByText('A').should('be.visible');
cy.findByText('X').should('be.visible');
cy.findByText('C').should('not.be.visible');
cy.get('[aria-rowindex="2"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();
cy.findByText('A').should('be.visible');
cy.findByText('X').should('be.visible');
cy.findByText('C').should('not.be.visible');
cy.get('[aria-rowindex="3"] > [aria-colindex="1"] > [title="Expand Node"] > [ui5-button]').click();
cy.findByText('A').should('be.visible');
cy.findByText('X').should('be.visible');
cy.findByText('C').should('not.be.visible');
if (zoom === '1') {
// Cypress' scrollTo('bottom') uses BCR-style coords and doesn't fire onLoadMore reliably under CSS zoom; verified at zoom=1 only
cy.get('[data-component-name="AnalyticalTableBody"]').scrollTo('bottom');
cy.get('@more').should('have.been.calledOnce');
}
expectBoundedAndReset();
});
});
});

if (reactVersion.startsWith('19')) {
Expand Down
7 changes: 5 additions & 2 deletions packages/main/src/components/AnalyticalTable/TableBody/RowSubComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ export function RowSubComponent(props: RowSubComponentProps) {
return;
}

const measureAndDispatch = (height: number) => {
const measureAndDispatch = (rawHeight: number) => {
// ceil: avoid under-estimation (would overlap next row) and absorb sub-px precision diff between getComputedStyle and borderBoxSize
const height = Math.ceil(rawHeight);
const prev: { rowId?: string; subComponentHeight?: number } = subComponentsHeight?.[virtualRow.index] ?? {};
if (height === 0 || (prev.subComponentHeight === height && prev.rowId === row.id)) {
return;
Expand Down Expand Up @@ -72,7 +74,8 @@ export function RowSubComponent(props: RowSubComponentProps) {
}
};

measureAndDispatch(subComponentElement.getBoundingClientRect().height);
// sync initial read for first-paint correctness; blockSize matches borderBoxSize coords (getBoundingClientRect returns zoom-applied)
measureAndDispatch(parseFloat(getComputedStyle(subComponentElement).blockSize));

const observer = new ResizeObserver(([entry]) => {
measureAndDispatch(entry.borderBoxSize[0].blockSize);
Expand Down
Loading