Skip to content

fix(ui5-carousel): remove redundant role="region" from section element - #13561

Merged
kskondov merged 3 commits into
mainfrom
ui5-carousel-roles
Jul 13, 2026
Merged

fix(ui5-carousel): remove redundant role="region" from section element#13561
kskondov merged 3 commits into
mainfrom
ui5-carousel-roles

Conversation

@kskondov

Copy link
Copy Markdown
Contributor

The <section> element already has an implicit ARIA role of "region", making the explicit attribute unnecessary and flagged by validators.
Fixes: #11515

The <section> element already has an implicit ARIA role of "region",
making the explicit attribute unnecessary and flagged by validators.
@kskondov
kskondov requested a review from a team May 20, 2026 11:38
@ui5-webcomponents-bot

ui5-webcomponents-bot commented May 20, 2026

Copy link
Copy Markdown
Collaborator

@ui5-webcomponents-bot
ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 11:44 Inactive
@ui5-webcomponents-bot
ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 12:25 Inactive
@ui5-webcomponents-bot
ui5-webcomponents-bot temporarily deployed to preview May 21, 2026 08:15 Inactive
@duygu-rmdn

Copy link
Copy Markdown
Member

ariaLabelTxt can return undefined when users don't provide accessibleName or accessibleNameRef (both are optional properties). i am not so sure but i think that this breaks landmark navigation for screen readers. Maybe as a possible fix try this one:

get ariaLabelTxt() {
      return getEffectiveAriaLabelText(this) ||
             Carousel.i18nBundle.getText(CAROUSEL_DEFAULT_LABEL);
  }

@kskondov
kskondov merged commit f512c2a into main Jul 13, 2026
13 checks passed
@kskondov
kskondov deleted the ui5-carousel-roles branch July 13, 2026 12:07
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🎉 This PR is included in version v2.25.0 🎉

The release is available on v2.25.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SFSF]Carousel: A11y - Elements must only use supported ARIA attributes

4 participants