Skip to content

fix(ui5-icon): suppress native click propagation for Image mode - #13997

Merged
NakataCode merged 2 commits into
mainfrom
icon-stop-propagation-non-interactive
Sep 3, 2026
Merged

fix(ui5-icon): suppress native click propagation for Image mode#13997
NakataCode merged 2 commits into
mainfrom
icon-stop-propagation-non-interactive

Conversation

@NakataCode

@NakataCode NakataCode commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Non-interactive Image mode already suppressed the ui5-click custom event, but the native click still bubbled up to the host, making the icon appear clickable to parent listeners.

Calls e.stopPropagation() in _onclick for Image mode before returning, aligning runtime behavior with the documented @event("click") specification.

Fixes: #13972

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@NakataCode NakataCode changed the title fix(ui5-icon): suppress native click propagation for non-interactive modes fix(ui5-icon): suppress native click propagation for Image mode Aug 28, 2026
@NakataCode
NakataCode merged commit 9ed07b6 into main Sep 3, 2026
13 checks passed
@NakataCode
NakataCode deleted the icon-stop-propagation-non-interactive branch September 3, 2026 11:54
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🧹 Preview deployment cleaned up: https://pr-13997--ui5-webcomponents.netlify.app

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🎉 This PR is included in version v2.27.0-rc.1 🎉

The release is available on v2.27.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[icons]: Icon mode="Image" announced as clickable and opens a dialog

2 participants