Skip to content

ui5-tokenizer: Necessary improvements for proper stylisation  #5096

@niyap

Description

@niyap

Bug Description

As part of the SAP Horizon themes implementation, I found out some issues in the ui5-tokenizer which affect the stylisation for all supported themes.

  1. The max-width of the tokenizer should be calculated according to the different use cases support (with button or without button). For reference, we can use openUI5 where it works as expected.
  2. In order to achieve the first point as well as to be able to adjust the inner input's padding based on the fact whether the component has button or not, we should provide a way to distinguish whether a button is presented or not.
  3. We have to provide a way to distinguish whether the ui5-multi-input/ui-multi-combobox contains token and to adjust the inner input paddings based on that
  4. Once the inner input paddings and the max-width are updated, we should remove the right margin of the N-more indicator as it is added as a workaround.
  5. We have to provide a class/attribute or private property which shows us whether the tokenizer is readonly(when the multiinput/multicombobox is readonly) or not as well as each separate token. Currently, the token's readonly styles are applied only when the "readonly" attribute is added explicitly to the token. When the ui5-multi-input/ui5-multi-combobox component iss not editable, the tokens are in their regular state which is not correct.
  6. Once, we have a way to distinguish whether the token is readonly or not based on the multiinput/multicombobox state, we have to remove the hover state stylings from readonly tokens.

Kind Regards,
Niya

Metadata

Metadata

Assignees

Type

No type

Projects

Status

New

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions