feat(ui5-popover): support setting "null" for opener #11995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
nnaydenow
reviewed
Jul 28, 2025
nnaydenow
approved these changes
Jul 28, 2025
Contributor
nnaydenow
left a comment
nnaydenow
left a comment
There was a problem hiding this comment.
1 minor comment but it looks good to me
Collaborator
|
🎉 This PR is included in version v2.13.0 🎉 The release is available on v2.13.0 Your semantic-release bot 📦🚀 |
nnaydenow
pushed a commit
that referenced
this pull request
Aug 18, 2025
Enable setting `null` for the `opener` property of popover-based components, such as: Popover, ResponsivePopover, Menu, UserMenu and more. The change is mainly to improve dev experience in React as it's typical to initialize [Refs](https://react.dev/reference/react/useRef#manipulating-the-dom-with-a-ref) with `null` (e.g., useRef<T>(null)), not undefined. Fixes: #11903 **Note:** With this change, when the opener is `null` or `undefined`, and `open` is set to `true`, the popover will be displayed in the top-left corner. Alternatively, we can change this behavior - to `close` the popover and fire `close` event, but either way, the opener should be fixed. Whether it shows in the top-left (0,0) coordinates or does not show at all, the popover won't work without opener.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable setting
nullfor theopenerproperty of popover-based components, such as: Popover, ResponsivePopover, Menu, UserMenu and more.The change is mainly to improve dev experience in React as it's typical to initialize Refs with
null(e.g., useRef(null)), not undefined.Fixes: #11903
Note: With this change, when the opener is
nullorundefined, andopenis set totrue, the popover will be displayed in the top-left corner. Alternatively, we can change this behavior - toclosethe popover and firecloseevent, but either way, the opener should be fixed. Whether it shows in the top-left (0,0) coordinates or does not show at all, the popover won't work without opener.