Skip to content

Conversation

@hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Oct 30, 2025

Fixes: #12346

@didip1000 didip1000 self-requested a review November 12, 2025 10:34
Copy link
Contributor

@didip1000 didip1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve because it works, but I don't think this is the right approach to solving the issue. Have you discussed with the core team to see if there's anything we can do with the late initial focus?

Also in terms of code style, you can get the cyan, and other swatch colors, and then assert that the swath is focused, instead of asserting if the swatch contains aria labels.

@hinzzx
Copy link
Contributor Author

hinzzx commented Nov 18, 2025

I'll approve because it works, but I don't think this is the right approach to solving the issue. Have you discussed with the core team to see if there's anything we can do with the late initial focus?

Also in terms of code style, you can get the cyan, and other swatch colors, and then assert that the swath is focused, instead of asserting if the swatch contains aria labels.

I dont think there is a problem with the initial focus, or at least there isnt any noticable or arising problem. In my opinion if there was anything to be concerned about, it would not be solvable by just rearraning the test.

Also as the aria labels and the values are inteded to be connected in a way, i think this is a great approach of testing both.

@tsanislavgatev tsanislavgatev merged commit e8baacc into main Nov 18, 2025
19 of 20 checks passed
@tsanislavgatev tsanislavgatev deleted the cpp-test-stabilisation branch November 18, 2025 12:22
@hinzzx hinzzx changed the title test(ui5-color-palette-popover): stabilise unstable tests [WIP] test(ui5-color-palette-popover): stabilise unstable tests Nov 18, 2025
@didip1000
Copy link
Contributor

For a human it's not a problem, the problem is that it gets picked up by cypress -> in onAfterRendering we await render to finish before applying focus, in the meantime Cypress waits for our control to render and then starts executing tests. I'm not sure if just adding tasks for cypress to execute to delay the check for focus will work in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ui5-color-palette]: failing tests

4 participants