Skip to content

test(ui5-color-palette-popover): stabilise unstable tests #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2025
Merged

test(ui5-color-palette-popover): stabilise unstable tests #12583

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4a49ed
test(ui5-color-palette-popover): stabilise unstable tests [WIP]
hinzzx Oct 29, 2025
0acc0c8
Merge branch 'main' into cpp-test-stabilisation
hinzzx Nov 7, 2025
c26c530
test(ui5-color-palette-popover): stabilise tests
hinzzx Nov 10, 2025
67e76e4
test(ui5-color-palette-popover): stabilise tests
hinzzx Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 107 additions & 19 deletions packages/main/cypress/specs/ColorPalettePopover.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,18 +372,50 @@ describe("Color Popover Palette arrow keys navigation", () => {
cy.get("[ui5-color-palette-popover]")
.ui5ColorPalettePopoverOpen({ opener: "btnPalette" });

cy.focused()
cy.get("[ui5-color-palette-popover]")
.should("have.attr", "open");

cy.get("[ui5-color-palette-popover]")
.ui5GetColorPaletteInPopover()
.as("colorPalette");

cy.get("@colorPalette")
.ui5GetColorPaletteDefaultButton()
.as("defaultColorButton")
.should("be.visible");

cy.get("@defaultColorButton")
.should("have.focus");

// Navigate right to first color item
cy.get("@defaultColorButton")
.realPress("ArrowRight");

cy.focused()
.should("have.attr", "aria-label")
cy.get("[ui5-color-palette-popover]")
.ui5GetColorPaletteItem(0)
.as("firstColorItem")
.should("be.visible")
.and("have.attr", "value", "cyan");

cy.get("@firstColorItem")
.should("have.attr", "value", "cyan");

cy.get("@firstColorItem")
.should("have.focus")
.shadow()
.find(".ui5-cp-item")
.should("have.attr", "tabindex", "0")
.and("have.attr", "aria-label")
.and("include", "cyan");

cy.focused()
.realPress("ArrowLeft");

cy.focused()
.should("have.attr", "aria-label", "Default Color");

cy.get("@defaultColorButton")
.should("have.focus");
});

it("should cycle through colors horizontally with left/right arrows", () => {
Expand Down Expand Up @@ -509,33 +541,75 @@ describe("Color Popover Palette arrow keys navigation", () => {
});

describe("Color Popover Palette Home and End keyboard navigation", () => {
it.skip("should navigate with Home/End when showDefaultColor is set", () => {
it("should navigate with Home/End when showDefaultColor is set", () => {
cy.mount(
<SimplePalettePopover showDefaultColor={true} />
);

cy.get("[ui5-color-palette-popover]")
.ui5ColorPalettePopoverOpen({ opener: "btnPalette" });

cy.focused()
cy.get("[ui5-color-palette-popover]")
.should("have.attr", "open");

cy.get("[ui5-color-palette-popover]")
.ui5GetColorPaletteInPopover()
.as("colorPalette");

cy.get("@colorPalette")
.ui5GetColorPaletteDefaultButton()
.as("defaultColorButton")
.should("be.visible")
.and("have.focus");

cy.get("@defaultColorButton")
.should("have.focus")
.shadow()
.find("button[data-sap-focus-ref]")
.should("have.focus");

cy.get("@defaultColorButton")
.realPress("End");

cy.focused()
.should("have.attr", "aria-label")
cy.get("[ui5-color-palette-popover]")
.ui5GetColorPaletteItem(3)
.as("lastColorPaletteItem")
.should("be.visible")
.and("have.attr", "value", "red");

cy.get("@lastColorPaletteItem")
.should("have.focus")
.shadow()
.find(".ui5-cp-item")
.should("have.attr", "tabindex", "0")
.and("have.attr", "aria-label")
.and("include", "red");

cy.focused()
.realPress("Home");

cy.focused()
.should("have.attr", "aria-label")
cy.get("[ui5-color-palette-popover]")
.ui5GetColorPaletteItem(0)
.as("firstColorPaletteItem")
.should("be.visible")
.and("have.attr", "value", "cyan");

cy.get("@firstColorPaletteItem")
.should("have.focus")
.shadow()
.find(".ui5-cp-item")
.should("have.attr", "tabindex", "0")
.and("have.attr", "aria-label")
.and("include", "cyan");

cy.focused()
.realPress("Home");

cy.focused()
.should("have.attr", "aria-label", "Default Color");

cy.get("@defaultColorButton")
.should("have.focus");
});

it("should navigate with Home/End keys when showMoreColors is set", () => {
Expand Down Expand Up @@ -564,28 +638,42 @@ describe("Color Popover Palette Home and End keyboard navigation", () => {
.should("have.attr", "aria-label", "More Colors...");
});

it.skip("should navigate with Home/End when showDefaultColor & showMoreColors are set", () => {
it("should navigate with Home/End when showDefaultColor & showMoreColors are set", () => {
cy.mount(
<SimplePalettePopover showDefaultColor={true} showMoreColors={true} />
);

cy.get("[ui5-color-palette-popover]")
cy.get<ColorPalettePopover>("[ui5-color-palette-popover]")
.as("colorPalettePopover")
.ui5ColorPalettePopoverOpen({ opener: "btnPalette" });

cy.focused()
.should("have.attr", "aria-label", "Default Color");
cy.get<ColorPalette>("@colorPalettePopover")
.ui5GetColorPaletteInPopover()
.as("colorPalette");

cy.focused()
cy.get("@colorPalette")
.ui5GetColorPaletteDefaultButton()
.as("defaultColorButton");

cy.get("@defaultColorButton")
.should("have.focus")
.realPress("End");

cy.focused()
.should("have.attr", "aria-label", "More Colors...");
cy.get("@colorPalette")
.ui5GetColorPaletteMoreColorsButton()
.as("moreColorsButton")
.should("be.visible");

cy.focused()
cy.get("@moreColorsButton")
.should("exist")
.and("be.visible")
.and("have.focus");

cy.get("@moreColorsButton")
.realPress("Home");

cy.focused()
.should("have.attr", "aria-label", "Default Color");
cy.get("@defaultColorButton")
.should("have.focus");
});

it("should navigate with End key", () => {
Expand Down
Loading