Skip to content

fix(build): fix issue with legacy dev setup #12706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
+3 −3
Merged

fix(build): fix issue with legacy dev setup #12706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/tools/components-package/nps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ const getScripts = (options) => {
},
copyProps: `ui5nps-script "${LIB}copy-and-watch/index.js" --silent "src/i18n/*.properties" dist/`,
copyPropsWithWatch: `ui5nps-script "${LIB}copy-and-watch/index.js" --silent "src/i18n/*.properties" dist/ --watch --safe --skip-initial-copy`,
copySrcWithWatch: `ui5nps-script "${LIB}copy-and-watch/index.js" --silent "src/**/*.{js,json}" dist/ --watch --safe --skip-initial-copy`,
copy: {
default: options.legacy ? "ui5nps copy.src copy.props" : "",
src: options.legacy ? `ui5nps-script "${LIB}copy-and-watch/index.js" --silent "src/**/*.{js,json}" dist/` : "",
Expand All @@ -137,7 +138,7 @@ const getScripts = (options) => {
watch: {
default: `ui5nps-p watch.templates watch.typescript watch.src watch.styles watch.i18n watch.props`, // concurently
devServer: 'ui5nps-p watch.default watch.bundle', // concurently
src: options.legacy ? 'ui5nps "copy.src --watch --safe --skip-initial-copy"' : "",
src: options.legacy ? 'ui5nps copySrcWithWatch' : "",
typescript: tsWatchCommandStandalone,
props: 'ui5nps copyPropsWithWatch',
bundle: `ui5nps-script ${LIB}dev-server/dev-server.mjs ${viteConfig}`,
Expand Down
3 changes: 1 addition & 2 deletions packages/tools/lib/i18n/toJSON.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ const convertToJSON = async (file, distPath) => {
const filename = path.basename(file, path.extname(file));
const language = filename.match(/^messagebundle_(.*?)$/)[1];
if (!allLanguages.includes(language)) {
console.log("Not supported language: ", language);
return;
console.warn("Not supported language or script: ", language);
}
const outputFile = path.normalize(`${distPath}/${filename}.json`);

Expand Down
Loading