Skip to content

Conversation

@didip1000
Copy link
Contributor

The close button in the ui5-menu on mobile devices has been changed from a "x" in the header to a "Cancel" button in the footer.

@didip1000 didip1000 requested a review from NHristov-sap January 9, 2026 10:25
@didip1000 didip1000 self-assigned this Jan 9, 2026
@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Jan 9, 2026

🧹 Preview deployment cleaned up: https://pr-12879--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 9, 2026 10:31 Inactive
@didip1000
Copy link
Contributor Author

Hey @UI5/ui5-team-ctr-rod,

I made some minor changes to the NavigationMenu if you could please take a look? The NavigationMenu looks quite a bit different from our menu and I couldn't find the close button to adapt it as well.

Thanks,
Diana

@TeodorTaushanov
Copy link
Member

Hey @UI5/ui5-team-ctr-rod,

I made some minor changes to the NavigationMenu if you could please take a look? The NavigationMenu looks quite a bit different from our menu and I couldn't find the close button to adapt it as well.

Thanks, Diana

Hello @didip1000, the NavigationMenu doesn't appear on mobile devices, so you can keep it unchanged.

@didip1000
Copy link
Contributor Author

Hey @TeodorTaushanov, In that case should I remove the entire "if is phone" conditional in the menu and menu item?

I cant leave it unchanged because I'm removing getters and message bundle texts that are currently being used in that menu.

@TeodorTaushanov
Copy link
Member

@didip1000, you can indeed remove "if is phone". Please make any necessary adjustments as needed.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 9, 2026 12:37 Inactive
@didip1000 didip1000 marked this pull request as ready for review January 12, 2026 09:39
@didip1000 didip1000 merged commit d3d85f6 into main Jan 12, 2026
21 of 22 checks passed
@didip1000 didip1000 deleted the menu-mobile-cancel branch January 12, 2026 09:40
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 12, 2026 09:40 Inactive
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.19.0-rc.1 🎉

The release is available on v2.19.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants