Skip to content

feat(ui5-color-palette*): resolve landmark uniqueness and missing dialog label #12967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hinzzx wants to merge 2 commits into
base: main
Choose a base branch
from
+45 −2
Open

feat(ui5-color-palette*): resolve landmark uniqueness and missing dialog label #12967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd1e6d1
fix(ui5-color-palette*): resolve landmark uniqueness and missing dial…
hinzzx Jan 27, 2026
ae71ecb
add accessibleNameRef
hinzzx Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/main/src/ColorPalette.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import event from "@ui5/webcomponents-base/dist/decorators/event-strict.js";
import jsxRenderer from "@ui5/webcomponents-base/dist/renderer/JsxRenderer.js";
import i18n from "@ui5/webcomponents-base/dist/decorators/i18n.js";
import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/AccessibilityTextsHelper.js";
import ItemNavigation from "@ui5/webcomponents-base/dist/delegate/ItemNavigation.js";
import type { ITabbable } from "@ui5/webcomponents-base/dist/delegate/ItemNavigation.js";
import ItemNavigationBehavior from "@ui5/webcomponents-base/dist/types/ItemNavigationBehavior.js";
Expand Down Expand Up @@ -132,6 +133,24 @@ class ColorPalette extends UI5Element {
@property()
defaultColor?: string;

/**
* Defines the accessible name of the component.
* @default undefined
* @public
* @since 2.20.0
*/
@property()
accessibleName?: string;

/**
* Receives id(or many ids) of the elements that label the component.
* @default undefined
* @public
* @since 2.20.0
*/
@property()
accessibleNameRef?: string;

/**
* Defines the selected color, only valid CSS color values accepted
* @private
Expand Down Expand Up @@ -883,7 +902,10 @@ class ColorPalette extends UI5Element {
}

get colorContainerLabel() {
return ColorPalette.i18nBundle.getText(COLORPALETTE_CONTAINER_LABEL);
const effectiveLabel = getEffectiveAriaLabelText(this);
return effectiveLabel
? `${ColorPalette.i18nBundle.getText(COLORPALETTE_CONTAINER_LABEL)} ${effectiveLabel}`
: ColorPalette.i18nBundle.getText(COLORPALETTE_CONTAINER_LABEL);
}

get colorPaletteMoreColorsText() {
Expand Down
18 changes: 18 additions & 0 deletions packages/main/src/ColorPalettePopover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,24 @@ class ColorPalettePopover extends UI5Element {
@property()
defaultColor?: string;

/**
* Defines the accessible name of the component.
* @default undefined
* @public
* @since 2.20.0
*/
@property()
accessibleName?: string;

/**
* Receives id(or many ids) of the elements that label the component.
* @default undefined
* @public
* @since 2.20.0
*/
@property()
accessibleNameRef?: string;

/**
* Defines the open | closed state of the popover.
* @public
Expand Down
3 changes: 3 additions & 0 deletions packages/main/src/ColorPalettePopoverTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default function ColorPalettePopoverTemplate(this: ColorPalettePopover) {
open={this._open}
onClose={this.onAfterClose}
onOpen={this.onAfterOpen}
accessibleName={this._colorPaletteTitle}
>
<div slot="header" class="ui5-cp-header">
<Title level="H1" wrappingType="None">
Expand All @@ -27,6 +28,8 @@ export default function ColorPalettePopoverTemplate(this: ColorPalettePopover) {
showRecentColors={this.showRecentColors}
showDefaultColor={this.showDefaultColor}
defaultColor={this.defaultColor}
accessibleName={this.accessibleName}
accessibleNameRef={this.accessibleNameRef}
popupMode={true}
onItemClick={this.onSelectedColor}
>
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/ColorPaletteTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default function ColorPaletteTemplate(this: ColorPalette) {
</div>
}
<div class="ui5-cp-item-container"
role="region"
role="group"
aria-label={this.colorContainerLabel}
onKeyDown={this._onColorContainerKeyDown}
>
Expand Down
Loading