Skip to content

fix(ui5-menu): improve accessibility for end content and loading state#13099

Merged
hinzzx merged 3 commits intomainfrom
menu-load-state-end-content-acc-fix
Mar 10, 2026
Merged

fix(ui5-menu): improve accessibility for end content and loading state#13099
hinzzx merged 3 commits intomainfrom
menu-load-state-end-content-acc-fix

Conversation

@hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Feb 16, 2026

Overview

During accessibility testing, two issues were identified:

  • ACC-255: Missing text alternative for end content slot
  • ACC-264: Loading state not announced to assistive technologies

What We Did

  • Wrapped end content slot in a group with accessible name "Additional Actions"
  • Added ARIA live region to announce loading state changes
  • Added aria-busy attribute to the menu content during loading
  • Added new i18n entries MENU_ITEM_END_CONTENT_ACCESSIBLE_NAME and MENU_ITEM_LOADING

What This Fixes

  • ✅ End content slot now has proper text alternative for screen readers
  • ✅ Loading state is announced when menu items are loading
  • ✅ No functional changes

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Feb 16, 2026

🧹 Preview deployment cleaned up: https://pr-13099--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 16, 2026 14:44 Inactive
@didip1000 didip1000 self-requested a review February 19, 2026 07:59
@unazko unazko self-requested a review February 23, 2026 04:56
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 26, 2026 12:51 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 4, 2026 08:10 Inactive
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Every loading state gets announced with JAWS and NVDA.

@unazko unazko requested a review from tsanislavgatev March 5, 2026 15:29
@didip1000 didip1000 removed their request for review March 6, 2026 11:58
@hinzzx hinzzx merged commit bece95c into main Mar 10, 2026
14 checks passed
@hinzzx hinzzx deleted the menu-load-state-end-content-acc-fix branch March 10, 2026 08:06
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 10, 2026 08:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants