fix(ui5-dynamic-page): guard against null scrollContainer in _toggleHeader#13255
Merged
fix(ui5-dynamic-page): guard against null scrollContainer in _toggleHeader#13255
Conversation
…eader When React renders DynamicPage with header-snapped attribute during initial mount, _toggleHeader can be called before the component's shadow DOM is rendered, causing scrollContainer to be null. Add null checks for scrollContainer in _toggleHeader, snapTitleByScroll, and onPinClick to prevent TypeError when the component is not yet fully initialized. Fixes #13236
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13255--ui5-webcomponents.netlify.app |
kgogov
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrollContainerin_toggleHeader,snapTitleByScroll, andonPinClickto preventTypeErrorwhen the component is not yet fully initializedscrollContainer!non-null assertions in favor of proper guards<ui5-dynamic-page header-snapped>during initial mount,attributeChangedCallbackfires before the shadow DOM is rendered, soscrollContainer(a@queryresult) isnullFixes #13236
Test plan
<ui5-dynamic-page header-snapped>no longer throws