fix(ui5-avatar-badge): handle delayed icon collection loading#13405
Merged
fix(ui5-avatar-badge): handle delayed icon collection loading#13405
Conversation
When an icon collection loader was registered but had not yet resolved, getIconDataSync() returned undefined and the sync onBeforeRendering immediately set invalid=true, permanently hiding the badge. Nothing ever cleared the flag because onBeforeRendering never re-ran. Fix: make onBeforeRendering async and fall back to await getIconData() when the sync lookup misses. The framework renders with the default invalid=false while the loader is pending, and the badge stays visible. Once the loader resolves the async continuation sets invalid correctly. Adds a Cypress regression test using a controlled deferred promise to verify the badge is never hidden while the loader is pending and the icon renders correctly after resolution. Fixes #13401
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13405--ui5-webcomponents.netlify.app |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
NakataCode
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an icon collection loader was registered but had not yet resolved, getIconDataSync() returned undefined and the sync onBeforeRendering immediately set invalid=true, permanently hiding the badge. Nothing ever cleared the flag because onBeforeRendering never re-ran.
Fix: make onBeforeRendering async and fall back to await getIconData() when the sync lookup misses. The framework renders with the default invalid=false while the loader is pending, and the badge stays visible. Once the loader resolves the async continuation sets invalid correctly.
Adds a Cypress regression test using a controlled deferred promise to verify the badge is never hidden while the loader is pending and the icon renders correctly after resolution.
Fixes #13401