ci: migrate remaining workflows from PAT to GitHub App token#13629
Merged
Conversation
Replace secrets.UI5_WEBCOMP_BOT_GH_TOKEN with a per-run installation token from actions/create-github-app-token@v3.2.0 (pinned by SHA) in: - deploy-preview.yaml - reset-preview-deploy.yaml - reset-gh-pages.yaml - issue-monthly-report.yaml Completes the OSPO Hardening Control #4 ("Replace long-lived secrets with OIDC") migration started in #13604. release.yaml was migrated there; this PR covers the four remaining workflows that were called out as out-of-scope at the time. Once merged and one run of each workflow is verified green, the UI5_WEBCOMP_BOT_GH_TOKEN secret can be deleted and the underlying PAT revoked. The UI5_WEBCOMP_BOT_NAME and UI5_WEBCOMP_BOT_EMAIL secrets are kept — they are git identity strings, not credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13604.
Replaces
secrets.UI5_WEBCOMP_BOT_GH_TOKENwith a per-run installation token fromactions/create-github-app-token@v3.2.0(pinned by SHA) in the four workflows that were intentionally left out of scope when the release workflow was migrated:deploy-preview.yamlreset-preview-deploy.yamlreset-gh-pages.yamlissue-monthly-report.yamlWhy
Completes the OSPO Hardening Control #4 migration: replace long-lived static credentials (PATs) with short-lived per-workflow tokens. App tokens are valid for ~1 hour and disappear when the run ends, drastically reducing the blast radius compared to the long-lived PAT.
After merge
Once each workflow has run green at least once, the
UI5_WEBCOMP_BOT_GH_TOKENsecret can be deleted and the underlying PAT revoked.UI5_WEBCOMP_BOT_NAMEandUI5_WEBCOMP_BOT_EMAILare kept — they are git identity strings, not credentials.Required (already in place from #13604)
RELEASE_APP_IDrepo secretRELEASE_APP_PRIVATE_KEYrepo secretsap-ui5-webcomponents-releaseGitHub App installed on this repo (only needs Contents/Issues/PRs write — no branch protection bypass changes required, since none of these workflows push tomain)