test(ui5-datetime-picker): skip flaky 'selection of 12:34:56 AM' test#13630
Merged
Conversation
This test has been failing intermittently on CI for weeks (predates the
recent autofocus PR). The 'Unstable test, needs investigation' note was
already in the file.
Likely root cause: TimeSelectionClocks._activateClock waits for an
'animationend' event to advance focus between hours/minutes/seconds. The
test calls setAnimationMode(AnimationMode.None), so 'animationend' never
fires and the next clock button never becomes focused, causing the
'.should("be.focused")' assertion to fail.
Skipping for now to unblock CI; the underlying component bug is tracked
separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skips the
tests selection of 12:34:56 AMtest inDateTimePicker.cy.tsx(usesit.skip).Why
This test has been failing intermittently on CI for weeks (failures go back to at least May 21, 2026 — well before the recent autofocus PR #12572). The file already had an
//Unstable test, needs investigationcomment above it.Likely root cause
TimeSelectionClocks._activateClockwaits for ananimationendevent to advance focus between hours / minutes / seconds clocks:The test calls
setAnimationMode(AnimationMode.None)to disable animations for determinism — but with animations disabled,animationendnever fires, so_activateClockis never invoked, and the next clock button never gets focused. The.should("be.focused")assertion then fails.The fix belongs in the component (skip the
animationendwait when animations are off, or call_activateClockdirectly whenskipAnimationis set in the relevant code path). Skipping the test for now unblocks CI while the component is investigated separately.Out of scope