fix(ui5-input): fire change in sync with the native input #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firing change event used to rely on the user input and did not consider changes through the "value" property. Now such changes are taken into count. In addition, the change event is also fired whenever suggestion item is selected. The issue can be observed in the ui5-datepicker. When the user types "tomorrow" and presses ENTER, everything is fine, the value in the input field changes to the particular date. But, when the user types "tomorrow" again - nothing happens, as the internal ui5-input does not fire "change" event. Fixes: #154
Bind to the native input "change" event and fire the ui5-input semantic one. Manually fire "change", when suggestion item is selected. Fixes: #154
ilhan007
changed the title
MapTo0
previously approved these changes
Mar 13, 2019
Contributor
MapTo0
left a comment
MapTo0
left a comment
There was a problem hiding this comment.
I would be happy if we also add a test for the datepicker's issue
MapTo0
approved these changes
Mar 13, 2019
Contributor
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bind to the native input "change" event and fire the ui5-input semantic one.
Manually fire "change", when suggestion item is selected.
Fixes: #154