Merged
Conversation
Adjust terms used because TeamResources use a composite primary key instead of an incremented ID. It was also necessary to turn off strict_trans_tables to avoid getting error: "Expression #2 of SELECT list is not in GROUP BY clause and c ontains nonaggregated column 'omeka_local.t0_.resource_id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by". This may require further attention.
Because team-resource is just a join table, no additional information is stored for an individual entity, i.e. it is nothing but the resource id and the team id. So, there is no point in a single entity read opperation. For search, this entity uses a composite key: team_id-resource_id, so search requests must have one of those elements instead of an entity id. Searching for a team will return all of its team resources, search for a resource will return all of the teams it belongs to.
While we consider which features whould be exposed to the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help prepare for a more substantial API overhaul, this just cleans up some loose ends by adding appropriate messages to the REST API and refactoring functionality to work as expected