-
Notifications
You must be signed in to change notification settings - Fork 14
Multi template tracking features/add multi template tracking map #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dcolli23
merged 18 commits into
fix_cloth_edge_visualization
from
multi_template_tracking_features/add_multi_template_tracking_map
Mar 27, 2023
Merged
Multi template tracking features/add multi template tracking map #48
dcolli23
merged 18 commits into
fix_cloth_edge_visualization
from
multi_template_tracking_features/add_multi_template_tracking_map
Mar 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still need to figure out how to best represent the max edge length. Perhaps a matrix will be sufficient if I extract the matrices in the same way each time (from the map). - On that note, the vertex and edge formation need to be updated to methods that access the map in the same order.
- Uses a member variable to keep track of the order with which we construct the edge and vertex matrices.
- Adds a routine to form the max segment length matrix for tracking multiple templates.
- Formats the method declarations in the CDCPD header.
- Updates the routines in CDCPD and Optimizer to accept max segment length Eigen row vectors (which are just Eigen matrices) instead of single values. This allows for the specification of max segment length dependent upon each edge.
- CDCPD now builds given the changes to the multi-template tracking map that were made. - The integration test needs to be modified to test this.
- Updates the static rope integration test to now work with the expected Eigen::RowVectorXd for max segment lengths of each edge.
- I was wrongly using a unique_ptr and it was killing the routine.
- Had a problem with not initializing the point cloud pointer which was causing crashes.
- Adds the launch file necessary to get the azure camera working with rope tracking (using the long rope).
- Updates the RVIZ edge visualization to only connect tracked points that belong to the same template. - Still need to iterate based on the edges and not the points as this assumption that points are connected sequentially is invalid for cloth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-Level Description
Adds the ability for CDCPD to run on multiple deformable object configurations by storing a map of configurations by unique ID (ID unique to each deformable object configuration). This isn't particularly important now but opens the possibility for tracking multiple templates in the future.
This does NOT implement multiple template tracking in the sense of:
Key Changes
Miscellaneous Changes