Skip to content

Conversation

@dcolli23
Copy link
Contributor

High-Level Description

Adds the ability for CDCPD to run on multiple deformable object configurations by storing a map of configurations by unique ID (ID unique to each deformable object configuration). This isn't particularly important now but opens the possibility for tracking multiple templates in the future.

This does NOT implement multiple template tracking in the sense of:

  • Learning separate LLE weights for separate templates given different initial template states.
  • Separating multiple deformable object configurations in the CPD step, meaning that the masked points that belong to another template still impact the CPD score of another, separate deformable object configuration.
  • Using masked point association history to disambiguate multi-template (non-instance) segmentation, meaning that if CDCPD receives a mask indicating there are two deformable objects in the segmentation that are interacting, there's no way to tell them apart in the tracking's use of the segmented mask.

Key Changes

  • Adds a std::map to keep track of deformable object configurations (how tracked templates are stored) by unique IDs.
  • Changes max segment length to be per edge so that edges can have different maximum lengths.
    • Something of this flavor is necessary to specify max edge lengths based on each template's (potentially different) edge lengths compared to any other template's edge lengths.
    • Though, it's up for debate as to whether this is the best way to handle this.
  • Updates the RVIZ edge visualization to only connect tracked points that belong to the same template.
    • Accomplishes this by publishing a MarkerArray message instead of a single Marker message.
    • TODO: Connect points based on the edge list. This would make the visualization respect the actual edges and thus correctly visualize cloth.

Miscellaneous Changes

  • Formats CDCPD and Optimizer function signatures as they could have been considered hard to read.

- Still need to figure out how to best represent the max edge length.
Perhaps a matrix will be sufficient if I extract the matrices in the
same way each time (from the map).
- On that note, the vertex and edge formation need to be updated to
methods that access the map in the same order.
- Uses a member variable to keep track of the order with which we
construct the edge and vertex matrices.
- Adds a routine to form the max segment length matrix for tracking
multiple templates.
- Formats the method declarations in the CDCPD header.
- Updates the routines in CDCPD and Optimizer to accept max segment
length Eigen row vectors (which are just Eigen matrices) instead of
single values. This allows for the specification of max segment
length dependent upon each edge.
- CDCPD now builds given the changes to the multi-template tracking
map that were made.
- The integration test needs to be modified to test this.
- Updates the static rope integration test to now work with the
expected Eigen::RowVectorXd for max segment lengths of each edge.
- I was wrongly using a unique_ptr and it was killing the routine.
- Had a problem with not initializing the point cloud pointer which
was causing crashes.
- Adds the launch file necessary to get the azure camera working
with rope tracking (using the long rope).
- Updates the RVIZ edge visualization to only connect tracked points
that belong to the same template.
- Still need to iterate based on the edges and not the points as this
assumption that points are connected sequentially is invalid for cloth
@dcolli23 dcolli23 added the enhancement New feature or request label Mar 27, 2023
@dcolli23 dcolli23 self-assigned this Mar 27, 2023
@dcolli23 dcolli23 merged commit 4ddbc8a into fix_cloth_edge_visualization Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants