Skip to content

fix(monitor-v2): ignore disputed requests for alerts#4813

Merged
daywiss merged 2 commits intomasterfrom
david/uma-2874-polymarket-bot-is-alerting-us-even-after-markets-are
Apr 1, 2025
Merged

fix(monitor-v2): ignore disputed requests for alerts#4813
daywiss merged 2 commits intomasterfrom
david/uma-2874-polymarket-bot-is-alerting-us-even-after-markets-are

Conversation

@daywiss
Copy link
Contributor

@daywiss daywiss commented Apr 1, 2025

Motivation

We are getting paged on markets which have been disputed, we can safely ignore those

Summary

Looks for disputes within the same window of proposals we are checking, ignores any proposals which were disputed

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

  • Ran end-to-end test, running the code as in production
  • New unit tests created
  • Existing tests adequate, no new tests required
  • All existing tests pass
  • Untested

@linear
Copy link

linear bot commented Apr 1, 2025

Signed-off-by: david <david@umaproject.org>
@daywiss daywiss force-pushed the david/uma-2874-polymarket-bot-is-alerting-us-even-after-markets-are branch from fa5f02f to 5ba9416 Compare April 1, 2025 17:43
Copy link
Contributor

@Reinis-FRP Reinis-FRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Signed-off-by: david <david@umaproject.org>
@daywiss daywiss merged commit 2333faa into master Apr 1, 2025
22 checks passed
@daywiss daywiss deleted the david/uma-2874-polymarket-bot-is-alerting-us-even-after-markets-are branch April 1, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants