Fix: bug in update roofs and walls temperatures with CRU data #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
🔍 Schema Preview DeployedPreview URLs:
Production URLs (unchanged):
|
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
Co-authored-by: dayantur <71443948+dayantur@users.noreply.github.com>
|
🤖 I've automatically formatted the code in this PR using:
Please pull the latest changes before making further edits. |
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
…correctly in the report
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
…on update_temperature_parameters
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
sunt05
requested changes
Oct 21, 2025
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
sunt05
approved these changes
Oct 21, 2025
sunt05
added a commit
that referenced
this pull request
Nov 20, 2025
Consistency improvements: - Removed all invalid [improvement] tags (changed to [maintenance]/[feature]) - Converted all markdown-style links [#123](URL) to simple format (#123) - Fixed all double parentheses issues ((#123)) → (#123) - Standardised all issue references to repository convention: (#xxx) Added PR numbers for audit trail: - November 2025: Added 13 PR numbers (#877, #874, #857, #843, #824, #820, #815, #814, #798, #808, #746, #773) - October 2025: Added 4 PR numbers (#767, #762, #736) Statistics: - Total 2025 entries: 215 - With PR/issue reference: 77 (35.8%, up from 30%) - All formatting now consistent across entire file 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
sunt05
added a commit
that referenced
this pull request
Nov 20, 2025
* docs: update changelog for 2025.11.20 * docs: add version history page for 2025.11.20 - Created v2025.11.20.rst with release highlights - Updated version-history.rst toctree - Updated release template to include version page creation step * docs: remove new_latest label from previous version The new_latest label should only appear on the most recent version page (v2025.11.20.rst), not on older versions. * docs: move version page creation to pre-flight checks Version history page should be prepared before release, not during. Also added reminder to remove new_latest label from previous version. * docs: remove orphaned dev label from version history The _dev label was left over from when there was a 'Recent Developments' heading. That section was replaced with a note, but the label remained. No references to this label exist in the documentation. * docs: clarify ERA5 data_source parameter changes Changed 'was earthkit' to 'replaces earthkit' to accurately reflect that this is a new implementation replacing the old approach, not a simple rename. Added explicit mention of earthkit.data dependency removal. * docs: rewrite ERA5 breaking changes to focus on new CDS timeseries data source Clarified that earthkit was never a user-facing parameter value. The change is about adopting the new CDS API timeseries data source by default, not about renaming parameters. * docs: cleanup and updates - Removed Doxyfile and api-doxygen.md - Updated documentation references and links - Minor documentation improvements * docs: standardise CHANGELOG.md formatting and add missing PR numbers Consistency improvements: - Removed all invalid [improvement] tags (changed to [maintenance]/[feature]) - Converted all markdown-style links [#123](URL) to simple format (#123) - Fixed all double parentheses issues ((#123)) → (#123) - Standardised all issue references to repository convention: (#xxx) Added PR numbers for audit trail: - November 2025: Added 13 PR numbers (#877, #874, #857, #843, #824, #820, #815, #814, #798, #808, #746, #773) - October 2025: Added 4 PR numbers (#767, #762, #736) Statistics: - Total 2025 entries: 215 - With PR/issue reference: 77 (35.8%, up from 30%) - All formatting now consistent across entire file 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Phase B validation updates initial surface temperatures from CRU TS4.06 climate data, but was missing roofs and wall arrays in initial_states. This meant these surfaces weren't getting proper CRU temperature initialisation.
Fix
This PR fixes the bug by extending
adjust_surface_temperatures()inphase_b.pyto update temperature fields in initial_states.roofs and initial_states.walls arrays. This fix ensures all surface temperature initialisation is consistent across initial states.Main Changes
phase_b.py(lines 912-964) by adding iteration through roofs/walls arrays after existing stebbs temperature updates, checking each element for temperature fields and updating to CRU-derived monthly average.