Skip to content

"per-slot" RX behavior assumes all radios on a frequency share the same parameters #35

@mrkline

Description

@mrkline

This shows up at a few different levels:

  1. In CalculateAudioParamsSync(), GetAnyTunedSlot() doesn't do a lookup based on (freq, slot), just returning the first slot that matches the frequency. This means that even if radios have different parameters (e.g., sensitivity), it will just grab one.
  2. The resulting audio params get pushed to _audioParamsCache, which is only keyed on frequency
  3. As a result, every "radio" - i.e. (freq, slot) pair - gets the same .CurrentParams for a given stream.

Probably not worth fixing in the near future since all radios in a given jet share the same RadioStationPreset, but FWIW doing the entire DSP pipeline (envelope calculation -> AGC -> squelch) would be cheap to do instead of splitting only squelch out per-radio.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions