-
Notifications
You must be signed in to change notification settings - Fork 89
添加*nix上对xdg spec的处理 #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加*nix上对xdg spec的处理 #245
Conversation
accesser/utils/importca.py
Outdated
| certpath = Path(setting.config['certpath']) | ||
| return | ||
|
|
||
| if sys.platform.startswith('win') or sys.platform.startswith('mac'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos 也是类 unix,应该和 unix 一样处理。(别问为什么上周 review 的现在才发,问就是才知道要 submit)
|
初始化顺序需要修改,目前certpath会在import时决定,但命令行参数要到main函数运行才会初始化 |
|
不想修初始化的bug,先把命令行参数去掉了 |
这两个在判断的时候都是直接引用 |
|
@Sving1024 命令行参数用不了,程序用配置时候只读了配置文件,没有读命令行参数 |
这些函数的调用都是在 Line 211 in 2896fc0
Line 239 in 2896fc0
Lines 245 to 248 in 2896fc0
Line 169 in 2896fc0
|
这样一开始是配置文件的值,然后变成命令行的值,潜在问题更大了。。 |
|
不就是很正常的让命令行选项覆盖配置文件的设置。 |
|
Accesser/accesser/utils/certmanager.py Lines 36 to 44 in 2896fc0
像这里就是命令行参数还没读,已经用了配置文件里的值 |
|
那至少 |
…/or other initiative.
windows的部分还是以前的逻辑没动