Skip to content

Conversation

@amm3
Copy link
Contributor

@amm3 amm3 commented Feb 11, 2020

I noticed a fairly common condition where base64 text was passed as HTTP post data, wherein the utility function URLDataToParameterDict would return a single element dictionary with a null value. This seems to occur when the base64 text is a null terminated string ending in a = character:

>>> postParams = util.URLDataToParameterDict('A=\0')
>>> postParams
{'A': '\x00'}

This was causing errors in the display of POST parameters and generally not useful in context of this decoder.

@amm3
Copy link
Contributor Author

amm3 commented Feb 11, 2020

Tacking on an additional commit to the DNS decoder, adding SOA record type handling and some minor code cleanup.

@dev195
Copy link
Contributor

dev195 commented Mar 2, 2020

Thanks for the update. I'm surprised we didn't notice that httpdump bug sooner.

@dev195 dev195 merged commit 2c63476 into USArmyResearchLab:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants