Conversation
This was
linked to
issues
Jun 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR applies a series of refactorings and updates to the netdiffuseR workshop materials, including new simulation examples for disadoption and multiadoption, documentation reorganization, and updates to the development container configuration. Key changes include:
- Addition of a new disadoption function (random_dis) and corresponding simulation examples.
- Updates to simulation examples with naming and parameter adjustments in the simulation QMD files.
- Removal and consolidation of obsolete content files and updated documentation/configuration files.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| files/sim-solutions-pt2-1.R | Added a disadoption function demonstrating random selection of 10% of adopters. |
| files/sim-solutions-pt1-1.R | Updated simulation examples using rdiffnet_multiple. |
| contents.qmd | Removed outdated content as part of the refactoring effort. |
| _quarto.yml & README.md | Updated website metadata and repository link. |
| 6-multi-and-dis.qmd | Introduced new examples for multiadoption and disadoption simulation. |
| 5-sim.qmd | Revised simulation examples with updated authorship and simulation parameters. |
| 4-stats.qmd & 3-visualization.qmd | Added updated statistical inference and visualization documents. |
| 2-read.qmd | Updated reading data examples with improved explanations and function usage. |
| 1-theory.qmd & 0-netdiffuser.qmd | Revised introductory and theoretical slides with minor formatting adjustments. |
| .devcontainer/* | Added and refined container configuration files for the development environment. |
Comments suppressed due to low confidence (1)
5-sim.qmd:101
- [nitpick] The names 'diffnet_disease' and 'diffnet_rumor' are used in close succession, which might lead to confusion. Consider renaming them consistently to clearly differentiate the simulation scenarios.
diffnet_disease <- rdiffnet(
| # selecting 10% of adopters to disadopt | ||
| list_disadopt[[q]] <- sample( | ||
| adopters_old, | ||
| round(0.10 * length(adopters_old) |
There was a problem hiding this comment.
Using round() for computing the number of disadoptions might round down to 0 in borderline cases; consider using ceiling() to ensure at least one node is selected when appropriate.
Suggested change
| round(0.10 * length(adopters_old) | |
| ceiling(0.10 * length(adopters_old) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of it thanks to @aoliveram. I'll be merging this so we can look at it live and comment later.
attn @twvalente