Updates to emis/proxies for failed QCs #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test code at bottom
nkruskamp
reviewed
Mar 18, 2025
| @@ -0,0 +1,439 @@ | |||
| # # %% | |||
nkruskamp
reviewed
Mar 18, 2025
| from gch4i.utils import tg_to_kt | ||
| #from gch4i.utils import tg_to_kt | ||
|
|
||
| tg_to_kt = 1000 |
Collaborator
There was a problem hiding this comment.
This is in utils as a constant? Why import separately?
nkruskamp
requested changes
Mar 18, 2025
Collaborator
nkruskamp
left a comment
nkruskamp
left a comment
There was a problem hiding this comment.
See some comments, and check abandoned coal file? Where did it come from, where did it go?
Collaborator
Author
|
@nkruskamp Please ignore this branch. My local branch crashed due to a OneDrive issue. I couldn't resolve all the issues, so I copied the relevant files that I needed to a backup directory, made a new branch, and pushed updated and corrected code from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emi Files:
task_iron_steel_emi - Review/updated Chris C's code
task_mobile_comb_emi - Updated code to take in 2022 mobile emi data, provided by EPA
task_petro_production_emi - Removing state_code from offshore emis
task_natural_gas_emis - Removing state_code from offshore emis
task_field_burning_emi - Adjusted code to only include states with atleast one emission. Should cause match between fbar emi/proxy.
Proxy Files:
task_stat_comb_proxy - normalization
task_fbar_proxy - changed source, normalization
task_farm_pipelines_proxy - normalization, remove state_code
task_lng_storage_proxy - normalization, remove state_code
task_trans_pipelines_proxy - normalization, remove state_code
task_storage_wells_proxy - normalization, remove state_code
task_ng_transmission_export_proxy - normalization, remove state_code
task_ng_transmission_import_proxy - normalization, remove state_code
task_abandoned_coal_proxy - adjusted code to remove null year values (did not drop at end, adjusted code)