Skip to content

Conversation

@burnettear
Copy link
Collaborator

post_code_review branch crashed/failed due to OneDrive issues. Multiples of files were retained once OneDrive was able to reconnect and it created 2 separate branches, neither of which I could push to.

To resolve, I copied my updated files to a backup directory; pulled main; created a new branch; and am pushing updates from the new (unbroken) branch: national_proxies.

Re: Nick's feedback from post_code_review

  • the correct task_abandoned_coal_proxy was added this time. Last time was an old version from a .scratch directory
  • task_field_burning_emi.py was updated to import tg_to_kt, instead of creating it in the code.

Emi Files:
task_iron_steel_emi - Review/updated Chris C's code
task_mobile_comb_emi - Updated code to take in 2022 mobile emi data, provided by EPA
task_petro_production_emi - Removing state_code from offshore emis
task_natural_gas_emis - Removing state_code from offshore emis
task_field_burning_emi - Adjusted code to only include states with atleast one emission. Should cause match between fbar emi/proxy.

Proxy Files:
task_stat_comb_proxy - normalization
task_mob_comb_railroads_proxy - Updated code to fix invalid geoms. May not be necessary to merge if you created different code for the final QC (I believe you did, but I included this just in case).
task_farm_pipelines_proxy - normalization, remove state_code
task_lng_storage_proxy - normalization, remove state_code
task_trans_pipelines_proxy - normalization, remove state_code
task_storage_wells_proxy - normalization, remove state_code
task_ng_transmission_export_proxy - normalization, remove state_code
task_ng_transmission_import_proxy - normalization, remove state_code
task_abandoned_coal_proxy - adjusted code to remove null year values (did not drop at end, adjusted code)

@burnettear burnettear requested a review from nkruskamp March 25, 2025 14:57
@nkruskamp nkruskamp merged commit c856ba9 into main Apr 2, 2025
@nkruskamp nkruskamp deleted the national_proxies branch April 2, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants