Replace fillna(0) with fillna(1) in example#557
Merged
kaklise merged 3 commits intoUSEPA:mainfrom May 4, 2026
Merged
Conversation
As per the comments in issue USEPA#549, demandless junctions are more accurately described as having 100% WSA, rather than 0% WSA (which technically means that 0% of the demand was met).
Collaborator
|
@wael-mahlous Thanks for submitting this update! I'll update the test files accordingly and get this merged. |
|
coverage: 85.769% (+0.01%) from 85.756% — wael-mahlous:fix-fillna into USEPA:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the comments in issue #549, demandless junctions are more accurately described as having 100% WSA, rather than 0% WSA (which technically means that 0% of the demand was met).
Summary
Resolves issue #549.
Tests and documentation
I believe that no tests/documentation updates are required for this.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.