Update: add enums to toolkit to enable clean error messages#558
Open
dbhart wants to merge 1 commit intoUSEPA:mainfrom
Open
Update: add enums to toolkit to enable clean error messages#558dbhart wants to merge 1 commit intoUSEPA:mainfrom
dbhart wants to merge 1 commit intoUSEPA:mainfrom
Conversation
|
coverage: 85.854% (+0.1%) from 85.756% — dbhart:main into USEPA:main |
kaklise
reviewed
May 4, 2026
Collaborator
kaklise
left a comment
kaklise
left a comment
There was a problem hiding this comment.
My understanding is that this is a replacement for the EN enum class, which is only used in BinFile.read and test_ENgetcount. Is that correct? To avoid duplication and potential errors, I suggest transitioning to the new enums before merging.
Contributor
Author
|
Sounds good, will do
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds clean enums to the toolkit to better get values during error handling.