47 updated bioactivity api vignette with mocked data tables and tcpl#59
Merged
Conversation
rachmaninoffpk
requested changes
Jun 7, 2024
Collaborator
rachmaninoffpk
left a comment
rachmaninoffpk
left a comment
There was a problem hiding this comment.
Everything looks good. There is an unstated dependency in the vignette. I think line 68 calls datatable from the DT package without the DT:: prefix. Please add the prefix to this and any other instance of DT functions being called, and include the DT package in imports/suggests of Description file and an importFrom call in the NAMESPACE file.
Collaborator
rachmaninoffpk
left a comment
rachmaninoffpk
left a comment
There was a problem hiding this comment.
Everything looks good and passes all checks.
Collaborator
rachmaninoffpk
left a comment
rachmaninoffpk
left a comment
There was a problem hiding this comment.
Everything checks out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated bioactivity api vignette with mocked data tables and references to the updates made to tcpl which integrates ccdR. Closes #47