Skip to content

Conversation

@cosden
Copy link
Member

@cosden cosden commented Jun 1, 2021

Posting another new RSE position at Princeton.

cc @usrse-maintainers

@danielskatz danielskatz merged commit 730d0b5 into master Jun 1, 2021
@danielskatz danielskatz deleted the add/job branch June 1, 2021 14:47
@vsoch
Copy link
Member

vsoch commented Jun 1, 2021

Did y'all see that the preview was broken? I tested the curl command locally and it does retrieve the REPO_ID (why the static files were not working, the REPO_ID was null).

Anyway I re-ran and all is well -> https://1257-120906408-gh.circle-artifacts.com/0/usrse.github.io/jobs/index.html in case you wanted to see the preview!

@danielskatz
Copy link
Contributor

that's strange - I checked the preview and it looked fine to me, then I merged. I wonder if this was related to you rerunning?

@vsoch
Copy link
Member

vsoch commented Jun 1, 2021

Yep I think so - I re-ran as soon as it originally turned green.

@vsoch
Copy link
Member

vsoch commented Jun 1, 2021

Here is the original run: https://1255-120906408-gh.circle-artifacts.com/0/usrse.github.io/jobs/index.html

image

If you look in the console you'll see the REPO_ID in the artifact paths is incorrect. It was just a bloop in retrieving it via the GitHub API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants