Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

  • Understand the project structure and requirements
  • Create vcpkg port structure (ports/ds directory)
    • Create vcpkg.json (port manifest)
    • Create portfile.cmake (simplified build instructions)
  • Modify CMakeLists.txt to add install targets for vcpkg compatibility
    • Add GNUInstallDirs include
    • Keep LTO always enabled (default behavior preserved)
    • Add install targets for library and headers
    • Add CMake export for find_package support
  • Test the build process
    • Verify library builds correctly
    • Verify install target works
    • Verify find_package works with installed library
Original prompt

This section details on the original issue you should resolve

<issue_title>添加对vcpkg的支持</issue_title>
<issue_description>可能应该需要添加一个vcpkg的ports, 但我很多年没用过vcpkg了, 不知道近期是否有格式的更新.
为了对vcpkg添加支持, 可能还需要修改cmakelists.txt, 如果可以, 尽量保持现在这样的静态链接, 因为这个包很需要lto.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@hzhangxyz hzhangxyz marked this pull request as ready for review December 3, 2025 01:47
Copilot AI review requested due to automatic review settings December 3, 2025 01:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI and others added 2 commits December 3, 2025 01:52
Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copilot AI changed the title [WIP] Add support for vcpkg package management Add vcpkg support Dec 3, 2025
Copilot AI requested a review from hzhangxyz December 3, 2025 01:54
@hzhangxyz
Copy link
Member

@copilot 不要使用lto这些开关, 让他保持默认行为就行.... 另外, ds-config.cmake是必须的么?如果不是必须的, 尽量少添加新的文件.

Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 3, 2025

@copilot 不要使用lto这些开关, 让他保持默认行为就行.... 另外, ds-config.cmake是必须的么?如果不是必须的, 尽量少添加新的文件.

Removed the DS_ENABLE_LTO option and DS_BUILD_EXAMPLES option - LTO is now always enabled as before. Also removed cmake/ds-config.cmake.in by using CMake's export directly to generate the config file, which is simpler and required for find_package() to work with vcpkg. (36280b7)

Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
@hzhangxyz hzhangxyz merged commit c4cb6d6 into main Dec 3, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

添加对vcpkg的支持

2 participants