feat(auth): refactor authentication plugin#103
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
|
||
| const TenantID = { | ||
| "ust.hk": "c917f3e2-9322-4926-9bb3-daca730413ca", | ||
| "connect.ust.hk": "6c1d4152-39d0-44ca-88d9-b8d6ddca0708", |
There was a problem hiding this comment.
App is using TenantID c917... and is working fine, why are we changing it?
There was a problem hiding this comment.
I am not really sure why the ust.hk tenant works fine, but theoretically we
should use the connect.ust.hk one for connect.ust.hk users and the ust.hk one
for ust.hk users. My guessing of why it works is that (1) both tenants share the
same JWKS (key set) (and in practice, most Azure OIDC uses the same key set);
and (2) the ust.hk tenant in app acts as the "issuer", and in practice a ust.hk
tenant can issue tokens on behalf of the connect.ust.hk tenant.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
aye aye, captain |

#101