feat: data quality UX - dashed imageless polygons, sidebar count fix (FE #70, Meta #5)#80
Open
madhavcodez wants to merge 1 commit into
Open
feat: data quality UX - dashed imageless polygons, sidebar count fix (FE #70, Meta #5)#80madhavcodez wants to merge 1 commit into
madhavcodez wants to merge 1 commit into
Conversation
…, dashed imageless polygons
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
l.geom IS NOT NULLin/locationsand/disasters/{id}/summary— locations without geometry were counted in sidebar but never rendered on map, causing "8 locations" vs 0 visible mismatchhasOverlayboolean on MapPolygon, dashed stroke for polygons without satellite imagery overlayGET /data-quality/report?disaster_id=...diagnostic endpoint — reports location/image-pair data quality metrics (null geometry, missing bounds, missing paths, unreferenced pairs) for storage analysisChanges
Backend (2 files)
app/main.py: Addedl.geom IS NOT NULLto/locationsand/disasters/{id}/summaryWHERE clauses; registered data_quality routerapp/routers/data_quality.py(NEW): Single diagnostic endpoint with efficient COUNT+FILTER SQL for location/image-pair quality metricsFrontend (3 files)
types.ts: AddedhasOverlay?: booleanto MapPolygon interfaceDashboard.tsx: ThreadhasOverlaythrough polygon parser, filter sidebar tile counts by geometry presenceMapView.tsx: Dashed stroke (dashArray: "6 4") for polygons wherehasOverlay === falseCloses UTDisaster/meta#5, #70, UTDisaster/meta#6
Test plan
GET /data-quality/report?disaster_id=hurricane-florencereturns valid JSON with all metricsGET /data-quality/reportwithout disaster_id returns 422