Merged
Conversation
Error and debug state enums Sensor and Arduino ID enums Structs: - Datum - single value+units - State - all datum+error+debug states) - Data - state+IDs, passed to computer Begin and update functions Constructor w/ allocation
…tronics-scripts into sensor-sptd25-20-1000h
Error and debug state enums Sensor and Arduino ID enums Structs: - Datum - single value+units - State - all datum+error+debug states) - Data - state+IDs, passed to computer Begin and update functions Constructor w/ allocation
…tronics-scripts into sensor-sptd25-20-1000h
read now passes by reference, rather than reference-reference (makes more sense, it's already allocated) const char* for units in t_datum proper
fixed - now semicolon-terminated struct members
…tronics-scripts into sensor-sptd25-20-1000h
urmilmodi
approved these changes
May 29, 2021
Member
urmilmodi
left a comment
urmilmodi
left a comment
There was a problem hiding this comment.
The child class operates, although the sensor needs to be calibrated.
Contributor
Author
|
@urmilmodi Can you add a screenshot of the sensor output when you get a chance? |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Script Author: Urmil Modi @urmilmodi
Current Hardware Owner: Urmil Modi @urmilmodi
Final Review: Urmil Modi @urmilmodi
Comment on this PR if you have any questions