Skip to content

Modifying params to data encoding functions#77

Merged
HermanG05 merged 5 commits intomainfrom
modifying-params-in-data-encoding
Feb 2, 2025
Merged

Modifying params to data encoding functions#77
HermanG05 merged 5 commits intomainfrom
modifying-params-in-data-encoding

Conversation

@HermanG05
Copy link
Contributor

The following function params were modified:

  • encode_metadata() in metadata_encoding_decoding.py
  • encode_position_global() in message_encoding_decoding.py

Copy link
Member

@maxlou05 maxlou05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

"""
try:
worker_id = worker_enum.WorkerEnum[worker_name.upper()]
if not worker_id: # If worker ID is not in the Enum Class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a check to make sure that it's part of the enum? Does this check that?

"""
try:
worker_id = worker_enum.WorkerEnum[worker_name.upper()]
if not worker_id: # If worker ID is not in the Enum Class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Member

@maxlou05 maxlou05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@HermanG05 HermanG05 merged commit a710405 into main Feb 2, 2025
1 check passed
@HermanG05 HermanG05 deleted the modifying-params-in-data-encoding branch February 2, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants